Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/orchestrator/taskreaper/task_reaper.go

Summary

Maintainability
D
2 days
Test Coverage

Method TaskReaper.tick has a Cognitive Complexity of 62 (exceeds 20 allowed). Consider refactoring.
Open

func (tr *TaskReaper) tick() {
    // this signals that a tick has occurred. it exists solely for testing.
    if tr.tickSignal != nil {
        // try writing to this channel, but if it's full, fall straight through
        // and ignore it.
Severity: Minor
Found in manager/orchestrator/taskreaper/task_reaper.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method TaskReaper.Run has a Cognitive Complexity of 50 (exceeds 20 allowed). Consider refactoring.
Open

func (tr *TaskReaper) Run(ctx context.Context) {
    watcher, watchCancel := state.Watch(tr.store.WatchQueue(), api.EventCreateTask{}, api.EventUpdateTask{}, api.EventUpdateCluster{})

    defer func() {
        close(tr.doneChan)
Severity: Minor
Found in manager/orchestrator/taskreaper/task_reaper.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method TaskReaper.Run has 91 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (tr *TaskReaper) Run(ctx context.Context) {
    watcher, watchCancel := state.Watch(tr.store.WatchQueue(), api.EventCreateTask{}, api.EventUpdateTask{}, api.EventUpdateCluster{})

    defer func() {
        close(tr.doneChan)
Severity: Major
Found in manager/orchestrator/taskreaper/task_reaper.go - About 2 hrs to fix

    Method TaskReaper.tick has 82 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (tr *TaskReaper) tick() {
    // this signals that a tick has occurred. it exists solely for testing.
    if tr.tickSignal != nil {
        // try writing to this channel, but if it's full, fall straight through
        // and ignore it.
    Severity: Major
    Found in manager/orchestrator/taskreaper/task_reaper.go - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status