Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/role_manager.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method roleManager.Run has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func (rm *roleManager) Run(ctx context.Context) {
    defer close(rm.doneChan)

    var (
        nodes []*api.Node
Severity: Minor
Found in manager/role_manager.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method roleManager.Run has 68 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (rm *roleManager) Run(ctx context.Context) {
    defer close(rm.doneChan)

    var (
        nodes []*api.Node
Severity: Minor
Found in manager/role_manager.go - About 1 hr to fix

    Method roleManager.reconcileRole has 6 return statements (exceeds 4 allowed).
    Open

    func (rm *roleManager) reconcileRole(ctx context.Context, node *api.Node) {
    if node.Role == node.Spec.DesiredRole {
        // Nothing to do.
        delete(rm.pendingReconciliation, node.ID)
        return
    Severity: Major
    Found in manager/role_manager.go - About 40 mins to fix

      Method roleManager.reconcileRole has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
      Open

      func (rm *roleManager) reconcileRole(ctx context.Context, node *api.Node) {
    if node.Role == node.Spec.DesiredRole {
        // Nothing to do.
        delete(rm.pendingReconciliation, node.ID)
        return
      Severity: Minor
      Found in manager/role_manager.go - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              err := rm.store.Update(func(tx store.Tx) error {
            updatedNode := store.GetNode(tx, node.ID)
            if updatedNode == nil || updatedNode.Spec.DesiredRole != node.Spec.DesiredRole || updatedNode.Role != node.Role {
                return nil
            }
      Severity: Major
      Found in manager/role_manager.go and 1 other location - About 1 hr to fix
      manager/role_manager.go on lines 240..247

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 136.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              err := rm.store.Update(func(tx store.Tx) error {
            updatedNode := store.GetNode(tx, node.ID)
            if updatedNode == nil || updatedNode.Spec.DesiredRole != node.Spec.DesiredRole || updatedNode.Role != node.Role {
                return nil
            }
      Severity: Major
      Found in manager/role_manager.go and 1 other location - About 1 hr to fix
      manager/role_manager.go on lines 264..272

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 136.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status