Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/scheduler/nodeset.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method nodeSet.tree has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
Open

func (ns *nodeSet) tree(serviceID string, preferences []*api.PlacementPreference, maxAssignments int, meetsConstraints func(*NodeInfo) bool, nodeLess func(*NodeInfo, *NodeInfo) bool) decisionTree {
    var root decisionTree

    if maxAssignments == 0 {
        return root
Severity: Minor
Found in manager/scheduler/nodeset.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method nodeSet.tree has 56 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (ns *nodeSet) tree(serviceID string, preferences []*api.PlacementPreference, maxAssignments int, meetsConstraints func(*NodeInfo) bool, nodeLess func(*NodeInfo, *NodeInfo) bool) decisionTree {
    var root decisionTree

    if maxAssignments == 0 {
        return root
Severity: Minor
Found in manager/scheduler/nodeset.go - About 1 hr to fix

    Method nodeSet.tree has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func (ns *nodeSet) tree(serviceID string, preferences []*api.PlacementPreference, maxAssignments int, meetsConstraints func(*NodeInfo) bool, nodeLess func(*NodeInfo, *NodeInfo) bool) decisionTree {
    Severity: Minor
    Found in manager/scheduler/nodeset.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status