Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/state/raft/storage.go

Summary

Maintainability
C
1 day
Test Coverage

Method Node.loadAndStart has a Cognitive Complexity of 54 (exceeds 20 allowed). Consider refactoring.
Open

func (n *Node) loadAndStart(ctx context.Context, forceNewCluster bool) error {
    snapshot, waldata, err := n.readFromDisk(ctx)
    if err != nil {
        return err
    }
Severity: Minor
Found in manager/state/raft/storage.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Node.loadAndStart has 81 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (n *Node) loadAndStart(ctx context.Context, forceNewCluster bool) error {
    snapshot, waldata, err := n.readFromDisk(ctx)
    if err != nil {
        return err
    }
Severity: Major
Found in manager/state/raft/storage.go - About 2 hrs to fix

    Method Node.triggerSnapshot has 53 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (n *Node) triggerSnapshot(ctx context.Context, raftConfig api.RaftConfig) {
    snapshot := api.Snapshot{Version: api.Snapshot_V0}
    for _, member := range n.cluster.Members() {
        snapshot.Membership.Members = append(snapshot.Membership.Members,
            &api.RaftMember{
    Severity: Minor
    Found in manager/state/raft/storage.go - About 1 hr to fix

      Method Node.loadAndStart has 8 return statements (exceeds 4 allowed).
      Open

      func (n *Node) loadAndStart(ctx context.Context, forceNewCluster bool) error {
    snapshot, waldata, err := n.readFromDisk(ctx)
    if err != nil {
        return err
    }
      Severity: Major
      Found in manager/state/raft/storage.go - About 50 mins to fix

        There are no issues that match your filters.

        Category
        Status