Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/state/raft/transport/peer.go

Summary

Maintainability
A
1 hr
Test Coverage

Method peer.sendProcessMessage has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p *peer) sendProcessMessage(ctx context.Context, m raftpb.Message) error {
    // These lines used to be in the code, but they've been removed. I'm
    // leaving them in in a comment just in case they cause some unforeseen
    // breakage later, to show why they were removed.
    //
Severity: Minor
Found in manager/state/raft/transport/peer.go - About 1 hr to fix

    Method peer.sendProcessMessage has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

    func (p *peer) sendProcessMessage(ctx context.Context, m raftpb.Message) error {
    // These lines used to be in the code, but they've been removed. I'm
    // leaving them in in a comment just in case they cause some unforeseen
    // breakage later, to show why they were removed.
    //
    Severity: Minor
    Found in manager/state/raft/transport/peer.go - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status