Sign upLogin

docker/swarmkit

View on GitHub
Star
manager/state/store/memory.go

Summary

Maintainability
F
3 days
Test Coverage

File memory.go has 772 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package store

import (
    "context"
    "errors"
Severity: Major
Found in manager/state/store/memory.go - About 1 day to fix

    Method readTx.findIterators has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
    Open

    func (tx readTx) findIterators(table string, by By, checkType func(By) error) ([]memdb.ResultIterator, error) {
    switch by.(type) {
    case byAll, orCombinator: // generic types
    default: // all other types
        if err := checkType(by); err != nil {
    Severity: Minor
    Found in manager/state/store/memory.go - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method readTx.findIterators has 159 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (tx readTx) findIterators(table string, by By, checkType func(By) error) ([]memdb.ResultIterator, error) {
    switch by.(type) {
    case byAll, orCombinator: // generic types
    default: // all other types
        if err := checkType(by); err != nil {
    Severity: Major
    Found in manager/state/store/memory.go - About 5 hrs to fix

      Method readTx.findIterators has 45 return statements (exceeds 4 allowed).
      Open

      func (tx readTx) findIterators(table string, by By, checkType func(By) error) ([]memdb.ResultIterator, error) {
    switch by.(type) {
    case byAll, orCombinator: // generic types
    default: // all other types
        if err := checkType(by); err != nil {
      Severity: Major
      Found in manager/state/store/memory.go - About 3 hrs to fix

        Method MemoryStore.update has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
        Open

        func (s *MemoryStore) update(proposer state.Proposer, cb func(Tx) error) error {
    defer metrics.StartTimer(updateLatencyTimer)()
    s.updateLock.Lock()
    memDBTx := s.memDB.Txn(true)
        Severity: Minor
        Found in manager/state/store/memory.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function WatchFrom has 57 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func WatchFrom(store *MemoryStore, version *api.Version, specifiers ...api.Event) (chan events.Event, func(), error) {
    if version == nil {
        ch, cancel := state.Watch(store.WatchQueue(), specifiers...)
        return ch, cancel, nil
    }
        Severity: Minor
        Found in manager/state/store/memory.go - About 1 hr to fix

          Method MemoryStore.update has 52 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (s *MemoryStore) update(proposer state.Proposer, cb func(Tx) error) error {
    defer metrics.StartTimer(updateLatencyTimer)()
    s.updateLock.Lock()
    memDBTx := s.memDB.Txn(true)
          Severity: Minor
          Found in manager/state/store/memory.go - About 1 hr to fix

            Function WatchFrom has 9 return statements (exceeds 4 allowed).
            Open

            func WatchFrom(store *MemoryStore, version *api.Version, specifiers ...api.Event) (chan events.Event, func(), error) {
    if version == nil {
        ch, cancel := state.Watch(store.WatchQueue(), specifiers...)
        return ch, cancel, nil
    }
            Severity: Major
            Found in manager/state/store/memory.go - About 55 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      select {
                        case <-commitGuard:
                            memDBTx.Commit()
                        default:
                            // Already Abort()ed.
              Severity: Major
              Found in manager/state/store/memory.go - About 45 mins to fix

                Method Batch.Update has 5 return statements (exceeds 4 allowed).
                Open

                func (batch *Batch) Update(cb func(Tx) error) error {
    if batch.err != nil {
        return batch.err
    }
                Severity: Major
                Found in manager/state/store/memory.go - About 35 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func fromArgs(args ...interface{}) ([]byte, error) {
    if len(args) != 1 {
        return nil, fmt.Errorf("must provide only a single argument")
    }
    arg, ok := args[0].(string)
                  Severity: Minor
                  Found in manager/state/store/memory.go and 1 other location - About 40 mins to fix
                  api/storeobject.go on lines 76..87

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 111.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status