docker/swarmkit

View on GitHub
swarmd/cmd/swarmctl/node/common.go

Summary

Maintainability
C
1 day
Test Coverage

Function updateNode has 8 return statements (exceeds 4 allowed).
Open

func updateNode(cmd *cobra.Command, args []string) error {
    if len(args) == 0 {
        return errors.New("node ID missing")
    }

Severity: Major
Found in swarmd/cmd/swarmctl/node/common.go - About 50 mins to fix

    Function changeNodeRole has 6 return statements (exceeds 4 allowed).
    Open

    func changeNodeRole(cmd *cobra.Command, args []string, role api.NodeRole) error {
        if len(args) == 0 {
            return errors.New("missing node ID")
        }
    
    
    Severity: Major
    Found in swarmd/cmd/swarmctl/node/common.go - About 40 mins to fix

      Function changeNodeAvailability has 6 return statements (exceeds 4 allowed).
      Open

      func changeNodeAvailability(cmd *cobra.Command, args []string, availability api.NodeSpec_Availability) error {
          if len(args) == 0 {
              return errors.New("missing node ID")
          }
      
      
      Severity: Major
      Found in swarmd/cmd/swarmctl/node/common.go - About 40 mins to fix

        Function getNode has 5 return statements (exceeds 4 allowed).
        Open

        func getNode(ctx context.Context, c api.ControlClient, input string) (*api.Node, error) {
            // GetNode to match via full ID.
            rg, err := c.GetNode(ctx, &api.GetNodeRequest{NodeID: input})
            if err != nil {
                // If any error (including NotFound), ListServices to match via full name.
        Severity: Major
        Found in swarmd/cmd/swarmctl/node/common.go - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func changeNodeAvailability(cmd *cobra.Command, args []string, availability api.NodeSpec_Availability) error {
              if len(args) == 0 {
                  return errors.New("missing node ID")
              }
          
          
          Severity: Major
          Found in swarmd/cmd/swarmctl/node/common.go and 1 other location - About 3 hrs to fix
          swarmd/cmd/swarmctl/node/common.go on lines 54..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 259.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func changeNodeRole(cmd *cobra.Command, args []string, role api.NodeRole) error {
              if len(args) == 0 {
                  return errors.New("missing node ID")
              }
          
          
          Severity: Major
          Found in swarmd/cmd/swarmctl/node/common.go and 1 other location - About 3 hrs to fix
          swarmd/cmd/swarmctl/node/common.go on lines 20..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 259.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func getNode(ctx context.Context, c api.ControlClient, input string) (*api.Node, error) {
              // GetNode to match via full ID.
              rg, err := c.GetNode(ctx, &api.GetNodeRequest{NodeID: input})
              if err != nil {
                  // If any error (including NotFound), ListServices to match via full name.
          Severity: Major
          Found in swarmd/cmd/swarmctl/node/common.go and 1 other location - About 2 hrs to fix
          swarmd/cmd/swarmctl/service/common.go on lines 10..37

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 240.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status