Sign upLogin

docker/swarmkit

View on GitHub
Star
swarmd/cmd/swarmctl/node/inspect.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function printNodeSummary has 86 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func printNodeSummary(node *api.Node) {
    w := tabwriter.NewWriter(os.Stdout, 8, 8, 8, ' ', 0)
    defer func() {
        // Ignore flushing errors - there's nothing we can do.
        _ = w.Flush()
Severity: Major
Found in swarmd/cmd/swarmctl/node/inspect.go - About 2 hrs to fix

    Function printNodeSummary has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
    Open

    func printNodeSummary(node *api.Node) {
    w := tabwriter.NewWriter(os.Stdout, 8, 8, 8, ' ', 0)
    defer func() {
        // Ignore flushing errors - there's nothing we can do.
        _ = w.Flush()
    Severity: Minor
    Found in swarmd/cmd/swarmctl/node/inspect.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status