Sign upLogin

docker/swarmkit

View on GitHub
Star
swarmd/cmd/swarmctl/service/flagparser/restart.go

Summary

Maintainability
A
1 hr
Test Coverage

Function parseRestart has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func parseRestart(flags *pflag.FlagSet, spec *api.ServiceSpec) error {
    if spec.Task.Restart == nil {
        // set new service's restart policy as RestartOnAny
        spec.Task.Restart = &api.RestartPolicy{
            Condition: api.RestartOnAny,
Severity: Minor
Found in swarmd/cmd/swarmctl/service/flagparser/restart.go - About 1 hr to fix

    Function parseRestart has 7 return statements (exceeds 4 allowed).
    Open

    func parseRestart(flags *pflag.FlagSet, spec *api.ServiceSpec) error {
    if spec.Task.Restart == nil {
        // set new service's restart policy as RestartOnAny
        spec.Task.Restart = &api.RestartPolicy{
            Condition: api.RestartOnAny,
    Severity: Major
    Found in swarmd/cmd/swarmctl/service/flagparser/restart.go - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status