Sign upLogin

docker/swarmkit

View on GitHub
Star
swarmd/cmd/swarmctl/service/flagparser/tmpfs.go

Summary

Maintainability
C
1 day
Test Coverage

Function parseTmpfs has a Cognitive Complexity of 54 (exceeds 20 allowed). Consider refactoring.
Open

func parseTmpfs(flags *pflag.FlagSet, spec *api.ServiceSpec) error {
    if flags.Changed("tmpfs") {
        tmpfss, err := flags.GetStringSlice("tmpfs")
        if err != nil {
            return err
Severity: Minor
Found in swarmd/cmd/swarmctl/service/flagparser/tmpfs.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseTmpfs has 76 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func parseTmpfs(flags *pflag.FlagSet, spec *api.ServiceSpec) error {
    if flags.Changed("tmpfs") {
        tmpfss, err := flags.GetStringSlice("tmpfs")
        if err != nil {
            return err
Severity: Major
Found in swarmd/cmd/swarmctl/service/flagparser/tmpfs.go - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                if err != nil {
                                return err
                            }
    Severity: Major
    Found in swarmd/cmd/swarmctl/service/flagparser/tmpfs.go - About 45 mins to fix

      Function parseTmpfs has 7 return statements (exceeds 4 allowed).
      Open

      func parseTmpfs(flags *pflag.FlagSet, spec *api.ServiceSpec) error {
    if flags.Changed("tmpfs") {
        tmpfss, err := flags.GetStringSlice("tmpfs")
        if err != nil {
            return err
      Severity: Major
      Found in swarmd/cmd/swarmctl/service/flagparser/tmpfs.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    switch suffix {
                            case 'g':
                                multiplier = 1 << 30
                            case 'm':
                                multiplier = 1 << 20
        Severity: Major
        Found in swarmd/cmd/swarmctl/service/flagparser/tmpfs.go - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status