docker/swarmkit

View on GitHub
swarmd/dockerexec/controller.go

Summary

Maintainability
C
1 day
Test Coverage

Method controller.Start has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

func (r *controller) Start(ctx context.Context) error {
    if err := r.checkClosed(); err != nil {
        return err
    }

Severity: Minor
Found in swarmd/dockerexec/controller.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method controller.Start has 61 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *controller) Start(ctx context.Context) error {
    if err := r.checkClosed(); err != nil {
        return err
    }

Severity: Minor
Found in swarmd/dockerexec/controller.go - About 1 hr to fix

    Method controller.Start has 15 return statements (exceeds 4 allowed).
    Open

    func (r *controller) Start(ctx context.Context) error {
        if err := r.checkClosed(); err != nil {
            return err
        }
    
    
    Severity: Major
    Found in swarmd/dockerexec/controller.go - About 1 hr to fix

      Method controller.Logs has 58 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (r *controller) Logs(ctx context.Context, publisher exec.LogPublisher, options api.LogSubscriptionOptions) error {
          if err := r.checkClosed(); err != nil {
              return err
          }
      
      
      Severity: Minor
      Found in swarmd/dockerexec/controller.go - About 1 hr to fix

        Method controller.Logs has 11 return statements (exceeds 4 allowed).
        Open

        func (r *controller) Logs(ctx context.Context, publisher exec.LogPublisher, options api.LogSubscriptionOptions) error {
            if err := r.checkClosed(); err != nil {
                return err
            }
        
        
        Severity: Major
        Found in swarmd/dockerexec/controller.go - About 1 hr to fix

          Method controller.Wait has 10 return statements (exceeds 4 allowed).
          Open

          func (r *controller) Wait(ctx context.Context) error {
              if err := r.checkClosed(); err != nil {
                  return err
              }
          
          
          Severity: Major
          Found in swarmd/dockerexec/controller.go - About 1 hr to fix

            Method controller.Wait has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
            Open

            func (r *controller) Wait(ctx context.Context) error {
                if err := r.checkClosed(); err != nil {
                    return err
                }
            
            
            Severity: Minor
            Found in swarmd/dockerexec/controller.go - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method controller.Prepare has 8 return statements (exceeds 4 allowed).
            Open

            func (r *controller) Prepare(ctx context.Context) error {
                if err := r.checkClosed(); err != nil {
                    return err
                }
            
            
            Severity: Major
            Found in swarmd/dockerexec/controller.go - About 50 mins to fix

              Method controller.Remove has 7 return statements (exceeds 4 allowed).
              Open

              func (r *controller) Remove(ctx context.Context) error {
                  if err := r.checkClosed(); err != nil {
                      return err
                  }
              
              
              Severity: Major
              Found in swarmd/dockerexec/controller.go - About 45 mins to fix

                Method controller.waitReady has 6 return statements (exceeds 4 allowed).
                Open

                func (r *controller) waitReady(pctx context.Context) error {
                    if err := r.checkClosed(); err != nil {
                        return err
                    }
                
                
                Severity: Major
                Found in swarmd/dockerexec/controller.go - About 40 mins to fix

                  Method controller.Logs has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func (r *controller) Logs(ctx context.Context, publisher exec.LogPublisher, options api.LogSubscriptionOptions) error {
                      if err := r.checkClosed(); err != nil {
                          return err
                      }
                  
                  
                  Severity: Minor
                  Found in swarmd/dockerexec/controller.go - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  There are no issues that match your filters.

                  Category
                  Status