Sign upLogin

dolittle/DotNET.SDK

View on GitHub
Star
Source/Events/Store/Converters/AggregateEventToSDKConverter.cs

Summary

Maintainability
B
6 hrs
Test Coverage
A
96%

Method TryConvert has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    bool TryConvert(
        Runtime.Events.Contracts.CommittedAggregateEvents.Types.CommittedAggregateEvent source,
        EventSourceId eventSourceId,
        AggregateRootId aggregateRootId,
        [NotNullWhen(true)] out CommittedAggregateEvent? result,
Severity: Minor
Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs - About 1 hr to fix

    Method TryConvert has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Runtime.Events.Contracts.CommittedAggregateEvents.Types.CommittedAggregateEvent source,
        EventSourceId eventSourceId,
        AggregateRootId aggregateRootId,
        [NotNullWhen(true)] out CommittedAggregateEvent? result,
        [NotNullWhen(false)] out Exception? error)
    Severity: Minor
    Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs - About 35 mins to fix

      Method TryConvert has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              IEnumerable<Runtime.Events.Contracts.CommittedAggregateEvents.Types.CommittedAggregateEvent> source,
        EventSourceId eventSourceId,
        AggregateRootId aggregateRootId,
        [NotNullWhen(true)] out List<CommittedAggregateEvent>? events,
        [NotNullWhen(false)] out Exception? error)
      Severity: Minor
      Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs - About 35 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return false;
            Severity: Major
            Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (!_serializer.TryDeserialize(eventType, source.EventLogSequenceNumber, source.Content, out var content, out var deserializationError))
        {
            error = new InvalidCommittedEventInformation(nameof(source.Content), deserializationError);
            return false;
        }
              Severity: Minor
              Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs and 1 other location - About 40 mins to fix
              Source/Events/Store/Converters/EventToSDKConverter.cs on lines 62..66

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (!source.EventType.TryTo<EventType, EventTypeId>(out var eventType, out var eventTypeError))
        {
            error = new InvalidCommittedEventInformation(nameof(source.EventType), eventTypeError);
            return false;
        }
              Severity: Minor
              Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs and 1 other location - About 35 mins to fix
              Source/Events/Store/Converters/EventToSDKConverter.cs on lines 50..54

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 63.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                      if (!source.AggregateRootId.TryTo<AggregateRootId>(out var aggregateRootId, out var aggregateRootIdError))
        {
            error = new InvalidCommittedEventInformation(nameof(source.AggregateRootId), aggregateRootIdError);
            return false;
        }
              Severity: Major
              Found in Source/Events/Store/Converters/AggregateEventToSDKConverter.cs and 4 other locations - About 30 mins to fix
              Source/Events.Processing/EventProcessingConverter.cs on lines 49..53
              Source/Protobuf/ExecutionContextExtensions.cs on lines 56..60
              Source/Protobuf/ExecutionContextExtensions.cs on lines 62..66
              Source/Protobuf/ExecutionContextExtensions.cs on lines 74..78

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 62.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status