dolittle/DotNET.SDK

View on GitHub
Source/Protobuf/ExecutionContextExtensions.cs

Summary

Maintainability
B
5 hrs
Test Coverage
D
67%

Method TryToExecutionContext has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static bool TryToExecutionContext(this PbExecutionContext source, out ExecutionContext executionContext, [NotNullWhen(false)] out Exception? error)
    {
        executionContext = default;

        if (source == default)
Severity: Minor
Found in Source/Protobuf/ExecutionContextExtensions.cs - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in Source/Protobuf/ExecutionContextExtensions.cs - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return false;
      Severity: Major
      Found in Source/Protobuf/ExecutionContextExtensions.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in Source/Protobuf/ExecutionContextExtensions.cs - About 30 mins to fix

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  if (!source.TenantId.TryTo<TenantId>(out var tenantId, out var tenantError))
                  {
                      error = new InvalidExecutionContextInformation(nameof(source.MicroserviceId), tenantError);
                      return false;
                  }
          Severity: Major
          Found in Source/Protobuf/ExecutionContextExtensions.cs and 4 other locations - About 30 mins to fix
          Source/Events.Processing/EventProcessingConverter.cs on lines 49..53
          Source/Events/Store/Converters/AggregateEventToSDKConverter.cs on lines 40..44
          Source/Protobuf/ExecutionContextExtensions.cs on lines 56..60
          Source/Protobuf/ExecutionContextExtensions.cs on lines 74..78

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  if (!source.MicroserviceId.TryTo<MicroserviceId>(out var microserviceId, out var microserviceError))
                  {
                      error = new InvalidExecutionContextInformation(nameof(source.MicroserviceId), microserviceError);
                      return false;
                  }
          Severity: Major
          Found in Source/Protobuf/ExecutionContextExtensions.cs and 4 other locations - About 30 mins to fix
          Source/Events.Processing/EventProcessingConverter.cs on lines 49..53
          Source/Events/Store/Converters/AggregateEventToSDKConverter.cs on lines 40..44
          Source/Protobuf/ExecutionContextExtensions.cs on lines 62..66
          Source/Protobuf/ExecutionContextExtensions.cs on lines 74..78

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                  if (!source.CorrelationId.TryTo<CorrelationId>(out var correlationId, out var correlationError))
                  {
                      error = new InvalidExecutionContextInformation(nameof(source.CorrelationId), correlationError);
                      return false;
                  }
          Severity: Major
          Found in Source/Protobuf/ExecutionContextExtensions.cs and 4 other locations - About 30 mins to fix
          Source/Events.Processing/EventProcessingConverter.cs on lines 49..53
          Source/Events/Store/Converters/AggregateEventToSDKConverter.cs on lines 40..44
          Source/Protobuf/ExecutionContextExtensions.cs on lines 56..60
          Source/Protobuf/ExecutionContextExtensions.cs on lines 62..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status