Sign upLogin

dominicsayers/foreplay

View on GitHub
Star
lib/foreplay.rb

Summary

Maintainability
A
45 mins
Test Coverage

Method supermerge has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def supermerge(other_hash)
    raise "supermerge needs a Hash, not a #{other_hash.class}." unless other_hash.is_a?(Hash)

    new_hash = deep_dup
Severity: Minor
Found in lib/foreplay.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Pass __FILE__ and __LINE__ to eval method, as they are used by backtraces.
Open

    gsub(/(<%=\s+([^%]+)\s+%>)/) { |e| eval "_ = #{e.split[1]}" } # rubocop:disable Security/Eval
Severity: Minor
Found in lib/foreplay.rb by rubocop

This cop checks eval method usage. eval can receive source location metadata, that are filename and line number. The metadata is used by backtraces. This cop recommends to pass the metadata to eval method.

Example:

# bad
eval <<-RUBY
  def do_something
  end
RUBY

# bad
C.class_eval <<-RUBY
  def do_something
  end
RUBY

# good
eval <<-RUBY, binding, __FILE__, __LINE__ + 1
  def do_something
  end
RUBY

# good
C.class_eval <<-RUBY, __FILE__, __LINE__ + 1
  def do_something
  end
RUBY

There are no issues that match your filters.

Category
Status