Sign upLogin

doodzik/visual-acceptance-test

View on GitHub
Star

Showing 8 of 8 total issues

Function testCase has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function testCase(element, index) {
    function contentOpts() {
        const id = +hashCode(element.path)
        const contentOpts = {id}
        if (element.isEqual) {
Severity: Minor
Found in src/confirmation/browser-view/content.js - About 1 hr to fix

    Function past has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        past () {
        return new Promise((resolve, reject) => {
            shell.exec('git status -s', (_code, stdout) => {
                this.checkout = stdout.length == 0
                return this.git.stash(['--all']).then(() => {
    Severity: Minor
    Found in src/time/last-commit.js - About 1 hr to fix

      Function evalImages has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function evalImages (imgA, imgB) {
    const height = imgA.height > imgB.height ? imgA.height : imgB.height
    const width  = imgA.width > imgB.width   ? imgA.width  : imgB.width
    var png = emptyPNG({width, height})
      Severity: Minor
      Found in src/imageDiff.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function evalImages has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function evalImages (imgA, imgB) {
    const height = imgA.height > imgB.height ? imgA.height : imgB.height
    const width  = imgA.width > imgB.width   ? imgA.width  : imgB.width
    var png = emptyPNG({width, height})
      Severity: Minor
      Found in src/imageDiff.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                app.post('/reject', (req, res) => {
            res.send('reject')
            destroy(server).then(() => resolve(1))
        })
        Severity: Minor
        Found in src/confirmation/browser.js and 1 other location - About 50 mins to fix
        src/confirmation/browser.js on lines 36..39

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                app.post('/acceptTest', (req, res) => {
            res.send('acceptTest')
            destroy(server).then(() => resolve(0))
        })
        Severity: Minor
        Found in src/confirmation/browser.js and 1 other location - About 50 mins to fix
        src/confirmation/browser.js on lines 31..34

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        png.data[idx+2] = (imgA.data[idx+2] + imgB.data[idx+2])/5
        Severity: Minor
        Found in src/imageDiff.js and 1 other location - About 45 mins to fix
        src/imageDiff.js on lines 126..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        png.data[idx+1] = (imgA.data[idx+1] + imgB.data[idx+1])/5
        Severity: Minor
        Found in src/imageDiff.js and 1 other location - About 45 mins to fix
        src/imageDiff.js on lines 127..127

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language