Sign upLogin

dotcloud/docker

View on GitHub
Star
api/server/router/build/build_routes.go

Summary

Maintainability
C
1 day
Test Coverage

Function newImageBuildOptions has 98 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func newImageBuildOptions(ctx context.Context, r *http.Request) (*types.ImageBuildOptions, error) {
    options := &types.ImageBuildOptions{
        Version:        types.BuilderV1, // Builder V1 is the default, but can be overridden
        Dockerfile:     r.FormValue("dockerfile"),
        SuppressOutput: httputils.BoolValue(r, "q"),
Severity: Major
Found in api/server/router/build/build_routes.go - About 2 hrs to fix

    Function newImageBuildOptions has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
    Open

    func newImageBuildOptions(ctx context.Context, r *http.Request) (*types.ImageBuildOptions, error) {
    options := &types.ImageBuildOptions{
        Version:        types.BuilderV1, // Builder V1 is the default, but can be overridden
        Dockerfile:     r.FormValue("dockerfile"),
        SuppressOutput: httputils.BoolValue(r, "q"),
    Severity: Minor
    Found in api/server/router/build/build_routes.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method buildRouter.postBuild has 54 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (br *buildRouter) postBuild(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    var (
        notVerboseBuffer = bytes.NewBuffer(nil)
        version          = httputils.VersionFromContext(ctx)
    )
    Severity: Minor
    Found in api/server/router/build/build_routes.go - About 1 hr to fix

      Function newImageBuildOptions has 10 return statements (exceeds 4 allowed).
      Open

      func newImageBuildOptions(ctx context.Context, r *http.Request) (*types.ImageBuildOptions, error) {
    options := &types.ImageBuildOptions{
        Version:        types.BuilderV1, // Builder V1 is the default, but can be overridden
        Dockerfile:     r.FormValue("dockerfile"),
        SuppressOutput: httputils.BoolValue(r, "q"),
      Severity: Major
      Found in api/server/router/build/build_routes.go - About 1 hr to fix

        Method buildRouter.postBuild has 7 return statements (exceeds 4 allowed).
        Open

        func (br *buildRouter) postBuild(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    var (
        notVerboseBuffer = bytes.NewBuffer(nil)
        version          = httputils.VersionFromContext(ctx)
    )
        Severity: Major
        Found in api/server/router/build/build_routes.go - About 45 mins to fix

          Method buildRouter.postPrune has 5 return statements (exceeds 4 allowed).
          Open

          func (br *buildRouter) postPrune(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }
    fltrs, err := filters.FromJSON(r.Form.Get("filters"))
          Severity: Major
          Found in api/server/router/build/build_routes.go - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status