Sign upLogin

dotcloud/docker

View on GitHub
Star
api/server/router/distribution/distribution_routes.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method distributionRouter.fetchManifest has 77 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (s *distributionRouter) fetchManifest(ctx context.Context, distrepo distribution.Repository, namedRef reference.Named) (registry.DistributionInspect, error) {
    var distributionInspect registry.DistributionInspect
    if canonicalRef, ok := namedRef.(reference.Canonical); !ok {
        namedRef = reference.TagNameOnly(namedRef)
Severity: Major
Found in api/server/router/distribution/distribution_routes.go - About 2 hrs to fix

    Method distributionRouter.fetchManifest has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
    Open

    func (s *distributionRouter) fetchManifest(ctx context.Context, distrepo distribution.Repository, namedRef reference.Named) (registry.DistributionInspect, error) {
    var distributionInspect registry.DistributionInspect
    if canonicalRef, ok := namedRef.(reference.Canonical); !ok {
        namedRef = reference.TagNameOnly(namedRef)
    Severity: Minor
    Found in api/server/router/distribution/distribution_routes.go - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method distributionRouter.getDistributionInfo has 7 return statements (exceeds 4 allowed).
    Open

    func (s *distributionRouter) getDistributionInfo(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }
    Severity: Major
    Found in api/server/router/distribution/distribution_routes.go - About 45 mins to fix

      Method distributionRouter.fetchManifest has 7 return statements (exceeds 4 allowed).
      Open

      func (s *distributionRouter) fetchManifest(ctx context.Context, distrepo distribution.Repository, namedRef reference.Named) (registry.DistributionInspect, error) {
    var distributionInspect registry.DistributionInspect
    if canonicalRef, ok := namedRef.(reference.Canonical); !ok {
        namedRef = reference.TagNameOnly(namedRef)
      Severity: Major
      Found in api/server/router/distribution/distribution_routes.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status