Sign upLogin

dotcloud/docker

View on GitHub
Star
api/server/router/swarm/helpers.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function adjustForAPIVersion has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
Open

func adjustForAPIVersion(cliVersion string, service *swarm.ServiceSpec) {
    if cliVersion == "" {
        return
    }
    if versions.LessThan(cliVersion, "1.46") {
Severity: Minor
Found in api/server/router/swarm/helpers.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function adjustForAPIVersion has 56 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func adjustForAPIVersion(cliVersion string, service *swarm.ServiceSpec) {
    if cliVersion == "" {
        return
    }
    if versions.LessThan(cliVersion, "1.46") {
Severity: Minor
Found in api/server/router/swarm/helpers.go - About 1 hr to fix

    Method swarmRouter.swarmLogs has 5 return statements (exceeds 4 allowed).
    Open

    func (sr *swarmRouter) swarmLogs(ctx context.Context, w http.ResponseWriter, r *http.Request, selector *backend.LogSelector) error {
    // Args are validated before the stream starts because when it starts we're
    // sending HTTP 200 by writing an empty chunk of data to tell the client that
    // daemon is going to stream. By sending this initial HTTP 200 we can't report
    // any error after the stream starts (i.e. container not found, wrong parameters)
    Severity: Major
    Found in api/server/router/swarm/helpers.go - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status