dotcloud/docker

View on GitHub
api/server/router/system/system_routes.go

Summary

Maintainability
C
1 day
Test Coverage

Method systemRouter.getDiskUsage has 82 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (s *systemRouter) getDiskUsage(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
    if err := httputils.ParseForm(r); err != nil {
        return err
    }

Severity: Major
Found in api/server/router/system/system_routes.go - About 2 hrs to fix

    Method systemRouter.getEvents has 78 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (s *systemRouter) getEvents(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
        if err := httputils.ParseForm(r); err != nil {
            return err
        }
    
    
    Severity: Major
    Found in api/server/router/system/system_routes.go - About 2 hrs to fix

      Method systemRouter.getDiskUsage has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
      Open

      func (s *systemRouter) getDiskUsage(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
          if err := httputils.ParseForm(r); err != nil {
              return err
          }
      
      
      Severity: Minor
      Found in api/server/router/system/system_routes.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method systemRouter.getEvents has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
      Open

      func (s *systemRouter) getEvents(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
          if err := httputils.ParseForm(r); err != nil {
              return err
          }
      
      
      Severity: Minor
      Found in api/server/router/system/system_routes.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method systemRouter.getInfo has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
      Open

      func (s *systemRouter) getInfo(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
          version := httputils.VersionFromContext(ctx)
          info, _, _ := s.collectSystemInfo.Do(ctx, version, func(ctx context.Context) (*system.Info, error) {
              info, err := s.backend.SystemInfo(ctx)
              if err != nil {
      Severity: Minor
      Found in api/server/router/system/system_routes.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method systemRouter.getEvents has 12 return statements (exceeds 4 allowed).
      Open

      func (s *systemRouter) getEvents(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
          if err := httputils.ParseForm(r); err != nil {
              return err
          }
      
      
      Severity: Major
      Found in api/server/router/system/system_routes.go - About 1 hr to fix

        Method systemRouter.getDiskUsage has 6 return statements (exceeds 4 allowed).
        Open

        func (s *systemRouter) getDiskUsage(ctx context.Context, w http.ResponseWriter, r *http.Request, vars map[string]string) error {
            if err := httputils.ParseForm(r); err != nil {
                return err
            }
        
        
        Severity: Major
        Found in api/server/router/system/system_routes.go - About 40 mins to fix

          There are no issues that match your filters.

          Category
          Status