Sign upLogin

dotcloud/docker

View on GitHub
Star
builder/builder-next/adapters/snapshot/layer.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method snapshotter.EnsureLayer has 71 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (s *snapshotter) EnsureLayer(ctx context.Context, key string) ([]layer.DiffID, error) {
    s.layerCreateLocker.Lock(key)
    defer s.layerCreateLocker.Unlock(key)

    diffIDs, err := s.GetDiffIDs(ctx, key)
Severity: Minor
Found in builder/builder-next/adapters/snapshot/layer.go - About 1 hr to fix

    Method snapshotter.EnsureLayer has 15 return statements (exceeds 4 allowed).
    Open

    func (s *snapshotter) EnsureLayer(ctx context.Context, key string) ([]layer.DiffID, error) {
    s.layerCreateLocker.Lock(key)
    defer s.layerCreateLocker.Unlock(key)

    diffIDs, err := s.GetDiffIDs(ctx, key)
    Severity: Major
    Found in builder/builder-next/adapters/snapshot/layer.go - About 1 hr to fix

      Method snapshotter.EnsureLayer has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
      Open

      func (s *snapshotter) EnsureLayer(ctx context.Context, key string) ([]layer.DiffID, error) {
    s.layerCreateLocker.Lock(key)
    defer s.layerCreateLocker.Unlock(key)

    diffIDs, err := s.GetDiffIDs(ctx, key)
      Severity: Minor
      Found in builder/builder-next/adapters/snapshot/layer.go - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status