Sign upLogin

dotcloud/docker

View on GitHub
Star
builder/builder-next/exporter/mobyexporter/export.go

Summary

Maintainability
C
1 day
Test Coverage

Method imageExporterInstance.Export has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
Open

func (e *imageExporterInstance) Export(ctx context.Context, inp *exporter.Source, inlineCache exptypes.InlineCache, sessionID string) (map[string]string, exporter.DescriptorReference, error) {
    if len(inp.Refs) > 1 {
        return nil, nil, fmt.Errorf("exporting multiple references to image store is currently unsupported")
    }
Severity: Minor
Found in builder/builder-next/exporter/mobyexporter/export.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method imageExporterInstance.Export has 106 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (e *imageExporterInstance) Export(ctx context.Context, inp *exporter.Source, inlineCache exptypes.InlineCache, sessionID string) (map[string]string, exporter.DescriptorReference, error) {
    if len(inp.Refs) > 1 {
        return nil, nil, fmt.Errorf("exporting multiple references to image store is currently unsupported")
    }
Severity: Major
Found in builder/builder-next/exporter/mobyexporter/export.go - About 3 hrs to fix

    Method imageExporterInstance.Export has 15 return statements (exceeds 4 allowed).
    Open

    func (e *imageExporterInstance) Export(ctx context.Context, inp *exporter.Source, inlineCache exptypes.InlineCache, sessionID string) (map[string]string, exporter.DescriptorReference, error) {
    if len(inp.Refs) > 1 {
        return nil, nil, fmt.Errorf("exporting multiple references to image store is currently unsupported")
    }
    Severity: Major
    Found in builder/builder-next/exporter/mobyexporter/export.go - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status