Sign upLogin

dotcloud/docker

View on GitHub
Star
builder/dockerfile/internals_windows.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function getAccountIdentity has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func getAccountIdentity(ctx context.Context, builder *Builder, accountName string, ctrRootPath string, state *dispatchState) (idtools.Identity, error) {
Severity: Minor
Found in builder/dockerfile/internals_windows.go - About 35 mins to fix

    Function parseChownFlag has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func parseChownFlag(ctx context.Context, builder *Builder, state *dispatchState, chown, ctrRootPath string, identityMapping idtools.IdentityMapping) (idtools.Identity, error) {
    Severity: Minor
    Found in builder/dockerfile/internals_windows.go - About 35 mins to fix

      Function lookupNTAccount has 5 return statements (exceeds 4 allowed).
      Open

      func lookupNTAccount(ctx context.Context, builder *Builder, accountName string, state *dispatchState) (idtools.Identity, error) {
    source, _ := filepath.Split(os.Args[0])

    target := "C:\\Docker"
    targetExecutable := target + "\\containerutility.exe"
      Severity: Major
      Found in builder/dockerfile/internals_windows.go - About 35 mins to fix

        Function getAccountIdentity has 5 return statements (exceeds 4 allowed).
        Open

        func getAccountIdentity(ctx context.Context, builder *Builder, accountName string, ctrRootPath string, state *dispatchState) (idtools.Identity, error) {
    // If this is potentially a string SID then attempt to convert it to verify
    // this, otherwise continue looking for the account.
    if strings.HasPrefix(accountName, "S-") || strings.HasPrefix(accountName, "s-") {
        sid, err := windows.StringToSid(accountName)
        Severity: Major
        Found in builder/dockerfile/internals_windows.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status