Sign upLogin

dotcloud/docker

View on GitHub
Star
client/container_create.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method Client.ContainerCreate has 51 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (cli *Client) ContainerCreate(ctx context.Context, config *container.Config, hostConfig *container.HostConfig, networkingConfig *network.NetworkingConfig, platform *ocispec.Platform, containerName string) (container.CreateResponse, error) {
    var response container.CreateResponse

    // Make sure we negotiated (if the client is configured to do so),
    // as code below contains API-version specific handling of options.
Severity: Minor
Found in client/container_create.go - About 1 hr to fix

    Method Client.ContainerCreate has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func (cli *Client) ContainerCreate(ctx context.Context, config *container.Config, hostConfig *container.HostConfig, networkingConfig *network.NetworkingConfig, platform *ocispec.Platform, containerName string) (container.CreateResponse, error) {
    Severity: Minor
    Found in client/container_create.go - About 45 mins to fix

      Method Client.ContainerCreate has 7 return statements (exceeds 4 allowed).
      Open

      func (cli *Client) ContainerCreate(ctx context.Context, config *container.Config, hostConfig *container.HostConfig, networkingConfig *network.NetworkingConfig, platform *ocispec.Platform, containerName string) (container.CreateResponse, error) {
    var response container.CreateResponse

    // Make sure we negotiated (if the client is configured to do so),
    // as code below contains API-version specific handling of options.
      Severity: Major
      Found in client/container_create.go - About 45 mins to fix

        Method Client.ContainerCreate has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func (cli *Client) ContainerCreate(ctx context.Context, config *container.Config, hostConfig *container.HostConfig, networkingConfig *network.NetworkingConfig, platform *ocispec.Platform, containerName string) (container.CreateResponse, error) {
    var response container.CreateResponse

    // Make sure we negotiated (if the client is configured to do so),
    // as code below contains API-version specific handling of options.
        Severity: Minor
        Found in client/container_create.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status