Sign upLogin

dotcloud/docker

View on GitHub
Star
client/request.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method Client.doRequest has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

func (cli *Client) doRequest(req *http.Request) (serverResponse, error) {
    serverResp := serverResponse{statusCode: -1, reqURL: req.URL}

    resp, err := cli.client.Do(req)
    if err != nil {
Severity: Minor
Found in client/request.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Client.doRequest has 8 return statements (exceeds 4 allowed).
Open

func (cli *Client) doRequest(req *http.Request) (serverResponse, error) {
    serverResp := serverResponse{statusCode: -1, reqURL: req.URL}

    resp, err := cli.client.Do(req)
    if err != nil {
Severity: Major
Found in client/request.go - About 50 mins to fix

    Method Client.checkResponseErr has 6 return statements (exceeds 4 allowed).
    Open

    func (cli *Client) checkResponseErr(serverResp serverResponse) error {
    if serverResp.statusCode >= 200 && serverResp.statusCode < 400 {
        return nil
    }
    Severity: Major
    Found in client/request.go - About 40 mins to fix

      Method Client.putRaw has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (cli *Client) putRaw(ctx context.Context, path string, query url.Values, body io.Reader, headers http.Header) (serverResponse, error) {
      Severity: Minor
      Found in client/request.go - About 35 mins to fix

        Method Client.postRaw has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (cli *Client) postRaw(ctx context.Context, path string, query url.Values, body io.Reader, headers http.Header) (serverResponse, error) {
        Severity: Minor
        Found in client/request.go - About 35 mins to fix

          Method Client.sendRequest has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (cli *Client) sendRequest(ctx context.Context, method, path string, query url.Values, body io.Reader, headers http.Header) (serverResponse, error) {
          Severity: Minor
          Found in client/request.go - About 35 mins to fix

            Method Client.post has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (cli *Client) post(ctx context.Context, path string, query url.Values, obj interface{}, headers http.Header) (serverResponse, error) {
            Severity: Minor
            Found in client/request.go - About 35 mins to fix

              Method Client.put has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func (cli *Client) put(ctx context.Context, path string, query url.Values, obj interface{}, headers http.Header) (serverResponse, error) {
              Severity: Minor
              Found in client/request.go - About 35 mins to fix

                There are no issues that match your filters.

                Category
                Status