Sign upLogin

dotcloud/docker

View on GitHub
Star
cmd/docker-proxy/main_linux.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function newProxy has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
Open

func newProxy(config ProxyConfig) (p Proxy, err error) {
    ipv := ip4
    if config.HostIP.To4() == nil {
        ipv = ip6
    }
Severity: Minor
Found in cmd/docker-proxy/main_linux.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function newProxy has 74 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func newProxy(config ProxyConfig) (p Proxy, err error) {
    ipv := ip4
    if config.HostIP.To4() == nil {
        ipv = ip6
    }
Severity: Minor
Found in cmd/docker-proxy/main_linux.go - About 1 hr to fix

    Function newProxy has 11 return statements (exceeds 4 allowed).
    Open

    func newProxy(config ProxyConfig) (p Proxy, err error) {
    ipv := ip4
    if config.HostIP.To4() == nil {
        ipv = ip6
    }
    Severity: Major
    Found in cmd/docker-proxy/main_linux.go - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status