Sign upLogin

dotcloud/docker

View on GitHub
Star
container/stream/attach.go

Summary

Maintainability
C
1 day
Test Coverage

Method Config.CopyStreams has a Cognitive Complexity of 53 (exceeds 20 allowed). Consider refactoring.
Open

func (c *Config) CopyStreams(ctx context.Context, cfg *AttachConfig) <-chan error {
    var group errgroup.Group

    // Connect stdin of container to the attach stdin stream.
    if cfg.Stdin != nil {
Severity: Minor
Found in container/stream/attach.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Config.CopyStreams has 93 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Config) CopyStreams(ctx context.Context, cfg *AttachConfig) <-chan error {
    var group errgroup.Group

    // Connect stdin of container to the attach stdin stream.
    if cfg.Stdin != nil {
Severity: Major
Found in container/stream/attach.go - About 2 hrs to fix

    Method Config.CopyStreams has 8 return statements (exceeds 4 allowed).
    Open

    func (c *Config) CopyStreams(ctx context.Context, cfg *AttachConfig) <-chan error {
    var group errgroup.Group

    // Connect stdin of container to the attach stdin stream.
    if cfg.Stdin != nil {
    Severity: Major
    Found in container/stream/attach.go - About 50 mins to fix

      There are no issues that match your filters.

      Category
      Status