Sign upLogin

dotcloud/docker

View on GitHub
Star
container/view.go

Summary

Maintainability
C
1 day
Test Coverage

Method View.transform has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
Open

func (v *View) transform(ctr *Container) *Snapshot {
    health := container.NoHealthcheck
    if ctr.Health != nil {
        health = ctr.Health.Status()
    }
Severity: Minor
Found in container/view.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method View.transform has 114 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (v *View) transform(ctr *Container) *Snapshot {
    health := container.NoHealthcheck
    if ctr.Health != nil {
        health = ctr.Health.Status()
    }
Severity: Major
Found in container/view.go - About 3 hrs to fix

    Method ViewDB.GetByPrefix has 5 return statements (exceeds 4 allowed).
    Open

    func (db *ViewDB) GetByPrefix(s string) (string, error) {
    if s == "" {
        return "", errdefs.InvalidParameter(errors.New("prefix can't be empty"))
    }
    iter, err := db.store.Txn(false).Get(memdbContainersTable, memdbIDIndexPrefix, s)
    Severity: Major
    Found in container/view.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (e *namesByNameIndexer) FromArgs(args ...interface{}) ([]byte, error) {
    if len(args) != 1 {
        return nil, fmt.Errorf("must provide only a single argument")
    }
    arg, ok := args[0].(string)
      Severity: Minor
      Found in container/view.go and 1 other location - About 50 mins to fix
      container/view.go on lines 499..509

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 120.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (e *namesByContainerIDIndexer) FromArgs(args ...interface{}) ([]byte, error) {
    if len(args) != 1 {
        return nil, fmt.Errorf("must provide only a single argument")
    }
    arg, ok := args[0].(string)
      Severity: Minor
      Found in container/view.go and 1 other location - About 50 mins to fix
      container/view.go on lines 474..484

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 120.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status