Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/archive_windows.go

Summary

Maintainability
C
1 day
Test Coverage

Method Daemon.containerExtractToDir has 66 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (daemon *Daemon) containerExtractToDir(container *container.Container, path string, copyUIDGID, noOverwriteDirNonDir bool, content io.Reader) (err error) {
    container.Lock()
    defer container.Unlock()

    // Make sure an online file-system operation is permitted.
Severity: Minor
Found in daemon/archive_windows.go - About 1 hr to fix

    Method Daemon.containerExtractToDir has 13 return statements (exceeds 4 allowed).
    Open

    func (daemon *Daemon) containerExtractToDir(container *container.Container, path string, copyUIDGID, noOverwriteDirNonDir bool, content io.Reader) (err error) {
    container.Lock()
    defer container.Unlock()

    // Make sure an online file-system operation is permitted.
    Severity: Major
    Found in daemon/archive_windows.go - About 1 hr to fix

      Method Daemon.containerCopy has 55 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (daemon *Daemon) containerCopy(container *container.Container, resource string) (rc io.ReadCloser, err error) {
    if resource[0] == '/' || resource[0] == '\\' {
        resource = resource[1:]
    }
    container.Lock()
      Severity: Minor
      Found in daemon/archive_windows.go - About 1 hr to fix

        Method Daemon.containerArchivePath has 53 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (daemon *Daemon) containerArchivePath(container *container.Container, path string) (content io.ReadCloser, stat *containertypes.PathStat, err error) {
    container.Lock()

    defer func() {
        if err != nil {
        Severity: Minor
        Found in daemon/archive_windows.go - About 1 hr to fix

          Method Daemon.containerCopy has 8 return statements (exceeds 4 allowed).
          Open

          func (daemon *Daemon) containerCopy(container *container.Container, resource string) (rc io.ReadCloser, err error) {
    if resource[0] == '/' || resource[0] == '\\' {
        resource = resource[1:]
    }
    container.Lock()
          Severity: Major
          Found in daemon/archive_windows.go - About 50 mins to fix

            Method Daemon.containerArchivePath has 8 return statements (exceeds 4 allowed).
            Open

            func (daemon *Daemon) containerArchivePath(container *container.Container, path string) (content io.ReadCloser, stat *containertypes.PathStat, err error) {
    container.Lock()

    defer func() {
        if err != nil {
            Severity: Major
            Found in daemon/archive_windows.go - About 50 mins to fix

              Method Daemon.containerExtractToDir has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
              Open

              func (daemon *Daemon) containerExtractToDir(container *container.Container, path string, copyUIDGID, noOverwriteDirNonDir bool, content io.Reader) (err error) {
    container.Lock()
    defer container.Unlock()

    // Make sure an online file-system operation is permitted.
              Severity: Minor
              Found in daemon/archive_windows.go - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method Daemon.containerStatPath has 5 return statements (exceeds 4 allowed).
              Open

              func (daemon *Daemon) containerStatPath(container *container.Container, path string) (stat *containertypes.PathStat, err error) {
    container.Lock()
    defer container.Unlock()

    // Make sure an online file-system operation is permitted.
              Severity: Major
              Found in daemon/archive_windows.go - About 35 mins to fix

                There are no issues that match your filters.

                Category
                Status