Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/attach.go

Summary

Maintainability
C
1 day
Test Coverage

Method Daemon.containerAttach has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
Open

func (daemon *Daemon) containerAttach(c *container.Container, cfg *stream.AttachConfig, logs, doStream bool) error {
    if logs {
        logDriver, logCreated, err := daemon.getLogger(c)
        if err != nil {
            return err
Severity: Minor
Found in daemon/attach.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Daemon.containerAttach has 70 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (daemon *Daemon) containerAttach(c *container.Container, cfg *stream.AttachConfig, logs, doStream bool) error {
    if logs {
        logDriver, logCreated, err := daemon.getLogger(c)
        if err != nil {
            return err
Severity: Minor
Found in daemon/attach.go - About 1 hr to fix

    Method Daemon.ContainerAttach has 63 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (daemon *Daemon) ContainerAttach(prefixOrName string, req *backend.ContainerAttachConfig) error {
    keys := []byte{}
    var err error
    if req.DetachKeys != "" {
        keys, err = term.ToBytes(req.DetachKeys)
    Severity: Minor
    Found in daemon/attach.go - About 1 hr to fix

      Method Daemon.ContainerAttach has 6 return statements (exceeds 4 allowed).
      Open

      func (daemon *Daemon) ContainerAttach(prefixOrName string, req *backend.ContainerAttachConfig) error {
    keys := []byte{}
    var err error
    if req.DetachKeys != "" {
        keys, err = term.ToBytes(req.DetachKeys)
      Severity: Major
      Found in daemon/attach.go - About 40 mins to fix

        Method Daemon.ContainerAttachRaw has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (daemon *Daemon) ContainerAttachRaw(prefixOrName string, stdin io.ReadCloser, stdout, stderr io.Writer, doStream bool, attached chan struct{}) error {
        Severity: Minor
        Found in daemon/attach.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status