Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/cluster/convert/service.go

Summary

Maintainability
D
2 days
Test Coverage

Function ServiceSpecToGRPC has a Cognitive Complexity of 58 (exceeds 20 allowed). Consider refactoring.
Open

func ServiceSpecToGRPC(s types.ServiceSpec) (swarmapi.ServiceSpec, error) {
    name := s.Name
    if name == "" {
        name = namesgenerator.GetRandomName(0)
    }
Severity: Minor
Found in daemon/cluster/convert/service.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ServiceSpecToGRPC has 175 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ServiceSpecToGRPC(s types.ServiceSpec) (swarmapi.ServiceSpec, error) {
    name := s.Name
    if name == "" {
        name = namesgenerator.GetRandomName(0)
    }
Severity: Major
Found in daemon/cluster/convert/service.go - About 6 hrs to fix

    File service.go has 599 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package convert // import "github.com/docker/docker/daemon/cluster/convert"

import (
    "fmt"
    "strings"
    Severity: Minor
    Found in daemon/cluster/convert/service.go - About 4 hrs to fix

      Function ServiceSpecToGRPC has 11 return statements (exceeds 4 allowed).
      Open

      func ServiceSpecToGRPC(s types.ServiceSpec) (swarmapi.ServiceSpec, error) {
    name := s.Name
    if name == "" {
        name = namesgenerator.GetRandomName(0)
    }
      Severity: Major
      Found in daemon/cluster/convert/service.go - About 1 hr to fix

        Function ServiceFromGRPC has 52 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func ServiceFromGRPC(s swarmapi.Service) (types.Service, error) {
    curSpec, err := serviceSpecFromGRPC(&s.Spec)
    if err != nil {
        return types.Service{}, err
    }
        Severity: Minor
        Found in daemon/cluster/convert/service.go - About 1 hr to fix

          Function serviceSpecFromGRPC has 51 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func serviceSpecFromGRPC(spec *swarmapi.ServiceSpec) (*types.ServiceSpec, error) {
    if spec == nil {
        return nil, nil
    }
          Severity: Minor
          Found in daemon/cluster/convert/service.go - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    switch s.UpdateStatus.State {
        case swarmapi.UpdateStatus_UPDATING:
            service.UpdateStatus.State = types.UpdateStateUpdating
        case swarmapi.UpdateStatus_PAUSED:
            service.UpdateStatus.State = types.UpdateStatePaused
            Severity: Major
            Found in daemon/cluster/convert/service.go and 1 other location - About 1 hr to fix
            daemon/cluster/executor/container/container.go on lines 322..335

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 164.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status