Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/cluster/executor/container/executor.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method executor.Configure has 82 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (e *executor) Configure(ctx context.Context, node *api.Node) error {
    var ingressNA *api.NetworkAttachment
    attachments := make(map[string]string)

    for _, na := range node.Attachments {
Severity: Major
Found in daemon/cluster/executor/container/executor.go - About 2 hrs to fix

    Method executor.Describe has 75 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (e *executor) Describe(ctx context.Context) (*api.NodeDescription, error) {
    info, err := e.backend.SystemInfo(ctx)
    if err != nil {
        return nil, err
    }
    Severity: Minor
    Found in daemon/cluster/executor/container/executor.go - About 2 hrs to fix

      Method executor.Configure has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
      Open

      func (e *executor) Configure(ctx context.Context, node *api.Node) error {
    var ingressNA *api.NetworkAttachment
    attachments := make(map[string]string)

    for _, na := range node.Attachments {
      Severity: Minor
      Found in daemon/cluster/executor/container/executor.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method executor.Controller has 6 return statements (exceeds 4 allowed).
      Open

      func (e *executor) Controller(t *api.Task) (exec.Controller, error) {
    dependencyGetter := template.NewTemplatedDependencyGetter(agent.Restrict(e.dependencies, t), t, nil)

    // Get the node description from the executor field
    e.mutex.Lock()
      Severity: Major
      Found in daemon/cluster/executor/container/executor.go - About 40 mins to fix

        Method executor.Describe has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
        Open

        func (e *executor) Describe(ctx context.Context) (*api.NodeDescription, error) {
    info, err := e.backend.SystemInfo(ctx)
    if err != nil {
        return nil, err
    }
        Severity: Minor
        Found in daemon/cluster/executor/container/executor.go - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status