Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/cluster/networks.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method Cluster.AttachNetwork has 57 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Cluster) AttachNetwork(target string, containerID string, addresses []string) (*network.NetworkingConfig, error) {
    aKey := attacherKey(target, containerID)
    c.mu.Lock()
    state := c.currentNodeState()
    if state.swarmNode == nil || state.swarmNode.Agent() == nil {
Severity: Minor
Found in daemon/cluster/networks.go - About 1 hr to fix

    Method Cluster.CreateNetwork has 5 return statements (exceeds 4 allowed).
    Open

    func (c *Cluster) CreateNetwork(s network.CreateRequest) (string, error) {
    if networkSettings.IsPredefined(s.Name) {
        err := notAllowedError(fmt.Sprintf("%s is a pre-defined network and cannot be created", s.Name))
        return "", errors.WithStack(err)
    }
    Severity: Major
    Found in daemon/cluster/networks.go - About 35 mins to fix

      Method Cluster.AttachNetwork has 5 return statements (exceeds 4 allowed).
      Open

      func (c *Cluster) AttachNetwork(target string, containerID string, addresses []string) (*network.NetworkingConfig, error) {
    aKey := attacherKey(target, containerID)
    c.mu.Lock()
    state := c.currentNodeState()
    if state.swarmNode == nil || state.swarmNode.Agent() == nil {
      Severity: Major
      Found in daemon/cluster/networks.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (c *Cluster) GetNetwork(input string) (network.Inspect, error) {
    var nw *swarmapi.Network

    if err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
        n, err := getNetwork(ctx, state.controlClient, input)
        Severity: Major
        Found in daemon/cluster/networks.go and 1 other location - About 1 hr to fix
        daemon/cluster/nodes.go on lines 51..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 171.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status