Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/cluster/services.go

Summary

Maintainability
F
5 days
Test Coverage

Method Cluster.UpdateService has a Cognitive Complexity of 58 (exceeds 20 allowed). Consider refactoring.
Open

func (c *Cluster) UpdateService(serviceIDOrName string, version uint64, spec swarm.ServiceSpec, flags types.ServiceUpdateOptions, queryRegistry bool) (*swarm.ServiceUpdateResponse, error) {
    var resp *swarm.ServiceUpdateResponse

    err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
        err := c.populateNetworkID(ctx, state.controlClient, &spec)
Severity: Minor
Found in daemon/cluster/services.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Cluster.ServiceLogs has a Cognitive Complexity of 56 (exceeds 20 allowed). Consider refactoring.
Open

func (c *Cluster) ServiceLogs(ctx context.Context, selector *backend.LogSelector, config *container.LogsOptions) (<-chan *backend.LogMessage, error) {
    c.mu.RLock()
    defer c.mu.RUnlock()

    state := c.currentNodeState()
Severity: Minor
Found in daemon/cluster/services.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Cluster.CreateService has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.
Open

func (c *Cluster) CreateService(s swarm.ServiceSpec, encodedAuth string, queryRegistry bool) (*swarm.ServiceCreateResponse, error) {
    var resp *swarm.ServiceCreateResponse
    err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
        err := c.populateNetworkID(ctx, state.controlClient, &s)
        if err != nil {
Severity: Minor
Found in daemon/cluster/services.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Cluster.ServiceLogs has 112 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Cluster) ServiceLogs(ctx context.Context, selector *backend.LogSelector, config *container.LogsOptions) (<-chan *backend.LogMessage, error) {
    c.mu.RLock()
    defer c.mu.RUnlock()

    state := c.currentNodeState()
Severity: Major
Found in daemon/cluster/services.go - About 3 hrs to fix

    Method Cluster.UpdateService has 100 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (c *Cluster) UpdateService(serviceIDOrName string, version uint64, spec swarm.ServiceSpec, flags types.ServiceUpdateOptions, queryRegistry bool) (*swarm.ServiceUpdateResponse, error) {
    var resp *swarm.ServiceUpdateResponse

    err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
        err := c.populateNetworkID(ctx, state.controlClient, &spec)
    Severity: Major
    Found in daemon/cluster/services.go - About 3 hrs to fix

      Method Cluster.GetServices has 90 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (c *Cluster) GetServices(options types.ServiceListOptions) ([]swarm.Service, error) {
    c.mu.RLock()
    defer c.mu.RUnlock()

    state := c.currentNodeState()
      Severity: Major
      Found in daemon/cluster/services.go - About 2 hrs to fix

        File services.go has 511 lines of code (exceeds 500 allowed). Consider refactoring.
        Open

        package cluster // import "github.com/docker/docker/daemon/cluster"

import (
    "context"
    "encoding/base64"
        Severity: Minor
        Found in daemon/cluster/services.go - About 2 hrs to fix

          Method Cluster.CreateService has 72 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (c *Cluster) CreateService(s swarm.ServiceSpec, encodedAuth string, queryRegistry bool) (*swarm.ServiceCreateResponse, error) {
    var resp *swarm.ServiceCreateResponse
    err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
        err := c.populateNetworkID(ctx, state.controlClient, &s)
        if err != nil {
          Severity: Minor
          Found in daemon/cluster/services.go - About 1 hr to fix

            Method Cluster.ServiceLogs has 12 return statements (exceeds 4 allowed).
            Open

            func (c *Cluster) ServiceLogs(ctx context.Context, selector *backend.LogSelector, config *container.LogsOptions) (<-chan *backend.LogMessage, error) {
    c.mu.RLock()
    defer c.mu.RUnlock()

    state := c.currentNodeState()
            Severity: Major
            Found in daemon/cluster/services.go - About 1 hr to fix

              Method Cluster.GetServices has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
              Open

              func (c *Cluster) GetServices(options types.ServiceListOptions) ([]swarm.Service, error) {
    c.mu.RLock()
    defer c.mu.RUnlock()

    state := c.currentNodeState()
              Severity: Minor
              Found in daemon/cluster/services.go - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method Cluster.CreateService has 9 return statements (exceeds 4 allowed).
              Open

              func (c *Cluster) CreateService(s swarm.ServiceSpec, encodedAuth string, queryRegistry bool) (*swarm.ServiceCreateResponse, error) {
    var resp *swarm.ServiceCreateResponse
    err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
        err := c.populateNetworkID(ctx, state.controlClient, &s)
        if err != nil {
              Severity: Major
              Found in daemon/cluster/services.go - About 55 mins to fix

                Method Cluster.imageWithDigestString has 9 return statements (exceeds 4 allowed).
                Open

                func (c *Cluster) imageWithDigestString(ctx context.Context, image string, authConfig *registry.AuthConfig) (string, error) {
    ref, err := reference.ParseAnyReference(image)
    if err != nil {
        return "", err
    }
                Severity: Major
                Found in daemon/cluster/services.go - About 55 mins to fix

                  Method Cluster.UpdateService has 9 return statements (exceeds 4 allowed).
                  Open

                  func (c *Cluster) UpdateService(serviceIDOrName string, version uint64, spec swarm.ServiceSpec, flags types.ServiceUpdateOptions, queryRegistry bool) (*swarm.ServiceUpdateResponse, error) {
    var resp *swarm.ServiceUpdateResponse

    err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
        err := c.populateNetworkID(ctx, state.controlClient, &spec)
                  Severity: Major
                  Found in daemon/cluster/services.go - About 55 mins to fix

                    Method Cluster.GetServices has 6 return statements (exceeds 4 allowed).
                    Open

                    func (c *Cluster) GetServices(options types.ServiceListOptions) ([]swarm.Service, error) {
    c.mu.RLock()
    defer c.mu.RUnlock()

    state := c.currentNodeState()
                    Severity: Major
                    Found in daemon/cluster/services.go - About 40 mins to fix

                      Method Cluster.UpdateService has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      func (c *Cluster) UpdateService(serviceIDOrName string, version uint64, spec swarm.ServiceSpec, flags types.ServiceUpdateOptions, queryRegistry bool) (*swarm.ServiceUpdateResponse, error) {
                      Severity: Minor
                      Found in daemon/cluster/services.go - About 35 mins to fix

                        Function convertSelector has 5 return statements (exceeds 4 allowed).
                        Open

                        func convertSelector(ctx context.Context, cc swarmapi.ControlClient, selector *backend.LogSelector) (*swarmapi.LogSelector, error) {
    // don't rely on swarmkit to resolve IDs, do it ourselves
    swarmSelector := &swarmapi.LogSelector{}
    for _, s := range selector.Services {
        service, err := getService(ctx, cc, s, false)
                        Severity: Major
                        Found in daemon/cluster/services.go - About 35 mins to fix

                          Method Cluster.GetService has 5 return statements (exceeds 4 allowed).
                          Open

                          func (c *Cluster) GetService(input string, insertDefaults bool) (swarm.Service, error) {
    var service *swarmapi.Service
    if err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
        s, err := getService(ctx, state.controlClient, input, insertDefaults)
        if err != nil {
                          Severity: Major
                          Found in daemon/cluster/services.go - About 35 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        if os.Getenv("DOCKER_SERVICE_PREFER_OFFLINE_IMAGE") != "1" && queryRegistry {
                digestImage, err := c.imageWithDigestString(ctx, ctnr.Image, authConfig)
                if err != nil {
                    log.G(ctx).Warnf("unable to pin image %s to digest: %s", ctnr.Image, err.Error())
                    // warning in the client response should be concise
                            Severity: Major
                            Found in daemon/cluster/services.go and 1 other location - About 2 hrs to fix
                            daemon/cluster/services.go on lines 363..386

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 238.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        if os.Getenv("DOCKER_SERVICE_PREFER_OFFLINE_IMAGE") != "1" && queryRegistry {
                digestImage, err := c.imageWithDigestString(ctx, newCtnr.Image, authConfig)
                if err != nil {
                    log.G(ctx).Warnf("unable to pin image %s to digest: %s", newCtnr.Image, err.Error())
                    // warning in the client response should be concise
                            Severity: Major
                            Found in daemon/cluster/services.go and 1 other location - About 2 hrs to fix
                            daemon/cluster/services.go on lines 247..270

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 238.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status