Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/commit.go

Summary

Maintainability
C
1 day
Test Coverage

Function merge has a Cognitive Complexity of 64 (exceeds 20 allowed). Consider refactoring.
Open

func merge(userConf, imageConf *containertypes.Config) error {
    if userConf.User == "" {
        userConf.User = imageConf.User
    }
    if len(userConf.ExposedPorts) == 0 {
Severity: Minor
Found in daemon/commit.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function merge has 88 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func merge(userConf, imageConf *containertypes.Config) error {
    if userConf.User == "" {
        userConf.User = imageConf.User
    }
    if len(userConf.ExposedPorts) == 0 {
Severity: Major
Found in daemon/commit.go - About 2 hrs to fix

    Method Daemon.CreateImageFromContainer has 56 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (daemon *Daemon) CreateImageFromContainer(ctx context.Context, name string, c *backend.CreateImageConfig) (string, error) {
    start := time.Now()

    container, err := daemon.GetContainer(name)
    if err != nil {
    Severity: Minor
    Found in daemon/commit.go - About 1 hr to fix

      Method Daemon.CreateImageFromContainer has 9 return statements (exceeds 4 allowed).
      Open

      func (daemon *Daemon) CreateImageFromContainer(ctx context.Context, name string, c *backend.CreateImageConfig) (string, error) {
    start := time.Now()

    container, err := daemon.GetContainer(name)
    if err != nil {
      Severity: Major
      Found in daemon/commit.go - About 55 mins to fix

        There are no issues that match your filters.

        Category
        Status