Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/containerd/image.go

Summary

Maintainability
D
2 days
Test Coverage

Method ImageService.resolveAllReferences has a Cognitive Complexity of 73 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) resolveAllReferences(ctx context.Context, refOrID string) (*containerdimages.Image, []containerdimages.Image, error) {
    parsed, err := reference.ParseAnyReference(refOrID)
    if err != nil {
        return nil, nil, errdefs.InvalidParameter(err)
    }
Severity: Minor
Found in daemon/containerd/image.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.resolveImage has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) resolveImage(ctx context.Context, refOrID string) (containerdimages.Image, error) {
    parsed, err := reference.ParseAnyReference(refOrID)
    if err != nil {
        return containerdimages.Image{}, errdefs.InvalidParameter(err)
    }
Severity: Minor
Found in daemon/containerd/image.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.resolveAllReferences has 102 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) resolveAllReferences(ctx context.Context, refOrID string) (*containerdimages.Image, []containerdimages.Image, error) {
    parsed, err := reference.ParseAnyReference(refOrID)
    if err != nil {
        return nil, nil, errdefs.InvalidParameter(err)
    }
Severity: Major
Found in daemon/containerd/image.go - About 3 hrs to fix

    Method ImageService.resolveImage has 64 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (i *ImageService) resolveImage(ctx context.Context, refOrID string) (containerdimages.Image, error) {
    parsed, err := reference.ParseAnyReference(refOrID)
    if err != nil {
        return containerdimages.Image{}, errdefs.InvalidParameter(err)
    }
    Severity: Minor
    Found in daemon/containerd/image.go - About 1 hr to fix

      Method ImageService.resolveAllReferences has 14 return statements (exceeds 4 allowed).
      Open

      func (i *ImageService) resolveAllReferences(ctx context.Context, refOrID string) (*containerdimages.Image, []containerdimages.Image, error) {
    parsed, err := reference.ParseAnyReference(refOrID)
    if err != nil {
        return nil, nil, errdefs.InvalidParameter(err)
    }
      Severity: Major
      Found in daemon/containerd/image.go - About 1 hr to fix

        Method ImageService.resolveImage has 14 return statements (exceeds 4 allowed).
        Open

        func (i *ImageService) resolveImage(ctx context.Context, refOrID string) (containerdimages.Image, error) {
    parsed, err := reference.ParseAnyReference(refOrID)
    if err != nil {
        return containerdimages.Image{}, errdefs.InvalidParameter(err)
    }
        Severity: Major
        Found in daemon/containerd/image.go - About 1 hr to fix

          Method ImageService.getBestPresentImageManifest has 5 return statements (exceeds 4 allowed).
          Open

          func (i *ImageService) getBestPresentImageManifest(ctx context.Context, img containerdimages.Image, pm platforms.MatchComparer) (*ImageManifest, error) {
    var best *ImageManifest
    var bestPlatform ocispec.Platform

    err := i.walkImageManifests(ctx, img, func(im *ImageManifest) error {
          Severity: Major
          Found in daemon/containerd/image.go - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status