Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/containerd/image_commit.go

Summary

Maintainability
C
1 day
Test Coverage

Method ImageService.createDiff has a Cognitive Complexity of 38 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) createDiff(ctx context.Context, name string, sn snapshots.Snapshotter, cs content.Store, comparer diff.Comparer) (*ocispec.Descriptor, digest.Digest, error) {
    info, err := sn.Stat(ctx, name)
    if err != nil {
        return nil, "", err
    }
Severity: Minor
Found in daemon/containerd/image_commit.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.createDiff has 89 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) createDiff(ctx context.Context, name string, sn snapshots.Snapshotter, cs content.Store, comparer diff.Comparer) (*ocispec.Descriptor, digest.Digest, error) {
    info, err := sn.Stat(ctx, name)
    if err != nil {
        return nil, "", err
    }
Severity: Major
Found in daemon/containerd/image_commit.go - About 2 hrs to fix

    Method ImageService.createDiff has 17 return statements (exceeds 4 allowed).
    Open

    func (i *ImageService) createDiff(ctx context.Context, name string, sn snapshots.Snapshotter, cs content.Store, comparer diff.Comparer) (*ocispec.Descriptor, digest.Digest, error) {
    info, err := sn.Stat(ctx, name)
    if err != nil {
        return nil, "", err
    }
    Severity: Major
    Found in daemon/containerd/image_commit.go - About 1 hr to fix

      Method ImageService.CommitImage has 8 return statements (exceeds 4 allowed).
      Open

      func (i *ImageService) CommitImage(ctx context.Context, cc backend.CommitConfig) (image.ID, error) {
    container := i.containers.Get(cc.ContainerID)
    cs := i.content

    var parentManifest ocispec.Manifest
      Severity: Major
      Found in daemon/containerd/image_commit.go - About 50 mins to fix

        Method ImageService.applyDiffLayer has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (i *ImageService) applyDiffLayer(ctx context.Context, name string, containerID string, sn snapshots.Snapshotter, differ diff.Applier, diffDesc ocispec.Descriptor) (retErr error) {
        Severity: Minor
        Found in daemon/containerd/image_commit.go - About 45 mins to fix

          Method ImageService.applyDiffLayer has 6 return statements (exceeds 4 allowed).
          Open

          func (i *ImageService) applyDiffLayer(ctx context.Context, name string, containerID string, sn snapshots.Snapshotter, differ diff.Applier, diffDesc ocispec.Descriptor) (retErr error) {
    // Let containerd know that this snapshot is only for diff-applying.
    key := snapshots.UnpackKeyPrefix + "-" + uniquePart() + "-" + name

    info, err := sn.Stat(ctx, containerID)
          Severity: Major
          Found in daemon/containerd/image_commit.go - About 40 mins to fix

            Method ImageService.createDiff has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (i *ImageService) createDiff(ctx context.Context, name string, sn snapshots.Snapshotter, cs content.Store, comparer diff.Comparer) (*ocispec.Descriptor, digest.Digest, error) {
            Severity: Minor
            Found in daemon/containerd/image_commit.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (i *ImageService) CommitBuildStep(ctx context.Context, c backend.CommitConfig) (image.ID, error) {
    ctr := i.containers.Get(c.ContainerID)
    if ctr == nil {
        // TODO: use typed error
        return "", fmt.Errorf("container not found: %s", c.ContainerID)
              Severity: Major
              Found in daemon/containerd/image_commit.go and 1 other location - About 1 hr to fix
              daemon/images/image_commit.go on lines 124..134

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 167.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status