Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/containerd/image_exporter.go

Summary

Maintainability
D
1 day
Test Coverage

Method ImageService.ExportImage has a Cognitive Complexity of 54 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) ExportImage(ctx context.Context, names []string, outStream io.Writer) error {
    platform := matchAllWithPreference(platforms.Default())
    opts := []archive.ExportOpt{
        archive.WithSkipNonDistributableBlobs(),
Severity: Minor
Found in daemon/containerd/image_exporter.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.ExportImage has 110 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) ExportImage(ctx context.Context, names []string, outStream io.Writer) error {
    platform := matchAllWithPreference(platforms.Default())
    opts := []archive.ExportOpt{
        archive.WithSkipNonDistributableBlobs(),
Severity: Major
Found in daemon/containerd/image_exporter.go - About 3 hrs to fix

    Method ImageService.LoadImage has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

    func (i *ImageService) LoadImage(ctx context.Context, inTar io.ReadCloser, outStream io.Writer, quiet bool) error {
    decompressed, err := dockerarchive.DecompressStream(inTar)
    if err != nil {
        return errors.Wrap(err, "failed to decompress input tar archive")
    }
    Severity: Minor
    Found in daemon/containerd/image_exporter.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ImageService.LoadImage has 66 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (i *ImageService) LoadImage(ctx context.Context, inTar io.ReadCloser, outStream io.Writer, quiet bool) error {
    decompressed, err := dockerarchive.DecompressStream(inTar)
    if err != nil {
        return errors.Wrap(err, "failed to decompress input tar archive")
    }
    Severity: Minor
    Found in daemon/containerd/image_exporter.go - About 1 hr to fix

      Method ImageService.ExportImage has 13 return statements (exceeds 4 allowed).
      Open

      func (i *ImageService) ExportImage(ctx context.Context, names []string, outStream io.Writer) error {
    platform := matchAllWithPreference(platforms.Default())
    opts := []archive.ExportOpt{
        archive.WithSkipNonDistributableBlobs(),
      Severity: Major
      Found in daemon/containerd/image_exporter.go - About 1 hr to fix

        Method ImageService.LoadImage has 10 return statements (exceeds 4 allowed).
        Open

        func (i *ImageService) LoadImage(ctx context.Context, inTar io.ReadCloser, outStream io.Writer, quiet bool) error {
    decompressed, err := dockerarchive.DecompressStream(inTar)
    if err != nil {
        return errors.Wrap(err, "failed to decompress input tar archive")
    }
        Severity: Major
        Found in daemon/containerd/image_exporter.go - About 1 hr to fix

          Function leaseContent has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func leaseContent(ctx context.Context, store content.Store, leasesManager leases.Manager, lease leases.Lease, desc ocispec.Descriptor) error {
          Severity: Minor
          Found in daemon/containerd/image_exporter.go - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status