Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/containerd/image_history.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method ImageService.ImageHistory has 90 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) ImageHistory(ctx context.Context, name string, platform *ocispec.Platform) ([]*imagetype.HistoryResponseItem, error) {
    start := time.Now()
    img, err := i.resolveImage(ctx, name)
    if err != nil {
        return nil, err
Severity: Major
Found in daemon/containerd/image_history.go - About 2 hrs to fix

    Method ImageService.ImageHistory has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
    Open

    func (i *ImageService) ImageHistory(ctx context.Context, name string, platform *ocispec.Platform) ([]*imagetype.HistoryResponseItem, error) {
    start := time.Now()
    img, err := i.resolveImage(ctx, name)
    if err != nil {
        return nil, err
    Severity: Minor
    Found in daemon/containerd/image_history.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ImageService.ImageHistory has 9 return statements (exceeds 4 allowed).
    Open

    func (i *ImageService) ImageHistory(ctx context.Context, name string, platform *ocispec.Platform) ([]*imagetype.HistoryResponseItem, error) {
    start := time.Now()
    img, err := i.resolveImage(ctx, name)
    if err != nil {
        return nil, err
    Severity: Major
    Found in daemon/containerd/image_history.go - About 55 mins to fix

      There are no issues that match your filters.

      Category
      Status