Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/containerd/image_inspect.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method ImageService.ImageInspect has 87 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) ImageInspect(ctx context.Context, refOrID string, _ backend.ImageInspectOpts) (*imagetypes.InspectResponse, error) {
    img, err := i.GetImage(ctx, refOrID, backend.GetImageOpts{})
    if err != nil {
        return nil, err
    }
Severity: Major
Found in daemon/containerd/image_inspect.go - About 2 hrs to fix

    Method ImageService.ImageInspect has 5 return statements (exceeds 4 allowed).
    Open

    func (i *ImageService) ImageInspect(ctx context.Context, refOrID string, _ backend.ImageInspectOpts) (*imagetypes.InspectResponse, error) {
    img, err := i.GetImage(ctx, refOrID, backend.GetImageOpts{})
    if err != nil {
        return nil, err
    }
    Severity: Major
    Found in daemon/containerd/image_inspect.go - About 35 mins to fix

      Method ImageService.ImageInspect has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

      func (i *ImageService) ImageInspect(ctx context.Context, refOrID string, _ backend.ImageInspectOpts) (*imagetypes.InspectResponse, error) {
    img, err := i.GetImage(ctx, refOrID, backend.GetImageOpts{})
    if err != nil {
        return nil, err
    }
      Severity: Minor
      Found in daemon/containerd/image_inspect.go - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status