Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/containerd/image_list.go

Summary

Maintainability
F
6 days
Test Coverage

Method ImageService.imageSummary has a Cognitive Complexity of 58 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) imageSummary(ctx context.Context, img images.Image, platformMatcher platforms.MatchComparer,
    opts imagetypes.ListOptions, tagsByDigest map[digest.Digest][]string,
) (_ *imagetypes.Summary, allChainIDs []digest.Digest, _ error) {
    var manifestSummaries []imagetypes.ManifestSummary
Severity: Minor
Found in daemon/containerd/image_list.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setupLabelFilter has a Cognitive Complexity of 54 (exceeds 20 allowed). Consider refactoring.
Open

func setupLabelFilter(ctx context.Context, store content.Store, fltrs filters.Args) (func(image images.Image) bool, error) {
    type labelCheck struct {
        key        string
        value      string
        onlyExists bool
Severity: Minor
Found in daemon/containerd/image_list.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.Images has a Cognitive Complexity of 53 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) Images(ctx context.Context, opts imagetypes.ListOptions) ([]*imagetypes.Summary, error) {
    if err := opts.Filters.Validate(acceptedImageFilterTags); err != nil {
        return nil, err
    }
Severity: Minor
Found in daemon/containerd/image_list.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.setupFilters has a Cognitive Complexity of 52 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) setupFilters(ctx context.Context, imageFilters filters.Args) (filterFunc imageFilterFunc, outErr error) {
    var fltrs []imageFilterFunc
    err := imageFilters.WalkValues("before", func(value string) error {
        img, err := i.GetImage(ctx, value, backend.GetImageOpts{})
        if err != nil {
Severity: Minor
Found in daemon/containerd/image_list.go - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.imageSummary has 142 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) imageSummary(ctx context.Context, img images.Image, platformMatcher platforms.MatchComparer,
    opts imagetypes.ListOptions, tagsByDigest map[digest.Digest][]string,
) (_ *imagetypes.Summary, allChainIDs []digest.Digest, _ error) {
    var manifestSummaries []imagetypes.ManifestSummary
Severity: Major
Found in daemon/containerd/image_list.go - About 4 hrs to fix

    File image_list.go has 602 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package containerd

import (
    "context"
    "encoding/json"
    Severity: Minor
    Found in daemon/containerd/image_list.go - About 4 hrs to fix

      Method ImageService.Images has 113 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (i *ImageService) Images(ctx context.Context, opts imagetypes.ListOptions) ([]*imagetypes.Summary, error) {
    if err := opts.Filters.Validate(acceptedImageFilterTags); err != nil {
        return nil, err
    }
      Severity: Major
      Found in daemon/containerd/image_list.go - About 3 hrs to fix

        Method ImageService.setupFilters has 100 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (i *ImageService) setupFilters(ctx context.Context, imageFilters filters.Args) (filterFunc imageFilterFunc, outErr error) {
    var fltrs []imageFilterFunc
    err := imageFilters.WalkValues("before", func(value string) error {
        img, err := i.GetImage(ctx, value, backend.GetImageOpts{})
        if err != nil {
        Severity: Major
        Found in daemon/containerd/image_list.go - About 3 hrs to fix

          Function setupLabelFilter has 78 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func setupLabelFilter(ctx context.Context, store content.Store, fltrs filters.Args) (func(image images.Image) bool, error) {
    type labelCheck struct {
        key        string
        value      string
        onlyExists bool
          Severity: Major
          Found in daemon/containerd/image_list.go - About 2 hrs to fix

            Method ImageService.setupFilters has 23 return statements (exceeds 4 allowed).
            Open

            func (i *ImageService) setupFilters(ctx context.Context, imageFilters filters.Args) (filterFunc imageFilterFunc, outErr error) {
    var fltrs []imageFilterFunc
    err := imageFilters.WalkValues("before", func(value string) error {
        img, err := i.GetImage(ctx, value, backend.GetImageOpts{})
        if err != nil {
            Severity: Major
            Found in daemon/containerd/image_list.go - About 2 hrs to fix

              Method ImageService.imageSummary has 13 return statements (exceeds 4 allowed).
              Open

              func (i *ImageService) imageSummary(ctx context.Context, img images.Image, platformMatcher platforms.MatchComparer,
    opts imagetypes.ListOptions, tagsByDigest map[digest.Digest][]string,
) (_ *imagetypes.Summary, allChainIDs []digest.Digest, _ error) {
    var manifestSummaries []imagetypes.ManifestSummary
              Severity: Major
              Found in daemon/containerd/image_list.go - About 1 hr to fix

                Method ImageService.Images has 12 return statements (exceeds 4 allowed).
                Open

                func (i *ImageService) Images(ctx context.Context, opts imagetypes.ListOptions) ([]*imagetypes.Summary, error) {
    if err := opts.Filters.Validate(acceptedImageFilterTags); err != nil {
        return nil, err
    }
                Severity: Major
                Found in daemon/containerd/image_list.go - About 1 hr to fix

                  Method ImageService.imageSummary has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func (i *ImageService) imageSummary(ctx context.Context, img images.Image, platformMatcher platforms.MatchComparer,
    opts imagetypes.ListOptions, tagsByDigest map[digest.Digest][]string,
                  Severity: Minor
                  Found in daemon/containerd/image_list.go - About 35 mins to fix

                    Function readJSON has 5 return statements (exceeds 4 allowed).
                    Open

                    func readJSON(ctx context.Context, store content.Provider, desc ocispec.Descriptor, out interface{}) error {
    data, err := content.ReadBlob(ctx, store, desc)
    if err != nil {
        err = errors.Wrapf(err, "failed to read config content")
        if cerrdefs.IsNotFound(err) {
                    Severity: Major
                    Found in daemon/containerd/image_list.go - About 35 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          err = imageFilters.WalkValues("since", func(value string) error {
        img, err := i.GetImage(ctx, value, backend.GetImageOpts{})
        if err != nil {
            return err
        }
                      Severity: Major
                      Found in daemon/containerd/image_list.go and 1 other location - About 2 hrs to fix
                      daemon/containerd/image_list.go on lines 518..533

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 198.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          err := imageFilters.WalkValues("before", func(value string) error {
        img, err := i.GetImage(ctx, value, backend.GetImageOpts{})
        if err != nil {
            return err
        }
                      Severity: Major
                      Found in daemon/containerd/image_list.go and 1 other location - About 2 hrs to fix
                      daemon/containerd/image_list.go on lines 538..553

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 198.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status