Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/containerd/image_prune.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method ImageService.unleaseSnapshotsFromDeletedConfigs has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) unleaseSnapshotsFromDeletedConfigs(ctx context.Context, possiblyDeletedConfigs map[digest.Digest]struct{}) error {
    all, err := i.images.List(ctx)
    if err != nil {
        return errors.Wrap(err, "failed to list images during snapshot lease removal")
    }
Severity: Minor
Found in daemon/containerd/image_prune.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.pruneAll has 54 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) pruneAll(ctx context.Context, imagesToPrune map[string]containerdimages.Image) (*image.PruneReport, error) {
    report := image.PruneReport{}

    ctx, span := tracing.StartSpan(ctx, "ImageService.pruneAll")
    span.SetAttributes(tracing.Attribute("count", len(imagesToPrune)))
Severity: Minor
Found in daemon/containerd/image_prune.go - About 1 hr to fix

    Method ImageService.pruneAll has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
    Open

    func (i *ImageService) pruneAll(ctx context.Context, imagesToPrune map[string]containerdimages.Image) (*image.PruneReport, error) {
    report := image.PruneReport{}

    ctx, span := tracing.StartSpan(ctx, "ImageService.pruneAll")
    span.SetAttributes(tracing.Attribute("count", len(imagesToPrune)))
    Severity: Minor
    Found in daemon/containerd/image_prune.go - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ImageService.unleaseSnapshotsFromDeletedConfigs has 6 return statements (exceeds 4 allowed).
    Open

    func (i *ImageService) unleaseSnapshotsFromDeletedConfigs(ctx context.Context, possiblyDeletedConfigs map[digest.Digest]struct{}) error {
    all, err := i.images.List(ctx)
    if err != nil {
        return errors.Wrap(err, "failed to list images during snapshot lease removal")
    }
    Severity: Major
    Found in daemon/containerd/image_prune.go - About 40 mins to fix

      Method ImageService.ImagesPrune has 5 return statements (exceeds 4 allowed).
      Open

      func (i *ImageService) ImagesPrune(ctx context.Context, fltrs filters.Args) (*image.PruneReport, error) {
    if !i.pruneRunning.CompareAndSwap(false, true) {
        return nil, errPruneRunning
    }
    defer i.pruneRunning.Store(false)
      Severity: Major
      Found in daemon/containerd/image_prune.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status