Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/containerd/image_pull.go

Summary

Maintainability
D
1 day
Test Coverage

Method ImageService.pullTag has a Cognitive Complexity of 70 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) pullTag(ctx context.Context, ref reference.Named, platform *ocispec.Platform, metaHeaders map[string][]string, authConfig *registrytypes.AuthConfig, out progress.Output) error {
    var opts []containerd.RemoteOpt
    if platform != nil {
        opts = append(opts, containerd.WithPlatform(platforms.Format(*platform)))
    }
Severity: Minor
Found in daemon/containerd/image_pull.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.pullTag has 130 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) pullTag(ctx context.Context, ref reference.Named, platform *ocispec.Platform, metaHeaders map[string][]string, authConfig *registrytypes.AuthConfig, out progress.Output) error {
    var opts []containerd.RemoteOpt
    if platform != nil {
        opts = append(opts, containerd.WithPlatform(platforms.Format(*platform)))
    }
Severity: Major
Found in daemon/containerd/image_pull.go - About 4 hrs to fix

    Method ImageService.pullTag has 12 return statements (exceeds 4 allowed).
    Open

    func (i *ImageService) pullTag(ctx context.Context, ref reference.Named, platform *ocispec.Platform, metaHeaders map[string][]string, authConfig *registrytypes.AuthConfig, out progress.Output) error {
    var opts []containerd.RemoteOpt
    if platform != nil {
        opts = append(opts, containerd.WithPlatform(platforms.Format(*platform)))
    }
    Severity: Major
    Found in daemon/containerd/image_pull.go - About 1 hr to fix

      Method ImageService.PullImage has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (i *ImageService) PullImage(ctx context.Context, baseRef reference.Named, platform *ocispec.Platform, metaHeaders map[string][]string, authConfig *registrytypes.AuthConfig, outStream io.Writer) (retErr error) {
      Severity: Minor
      Found in daemon/containerd/image_pull.go - About 45 mins to fix

        Method ImageService.pullTag has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (i *ImageService) pullTag(ctx context.Context, ref reference.Named, platform *ocispec.Platform, metaHeaders map[string][]string, authConfig *registrytypes.AuthConfig, out progress.Output) error {
        Severity: Minor
        Found in daemon/containerd/image_pull.go - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status