Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/containerd/progress.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method pushProgress.UpdateProgress has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func (p *pushProgress) UpdateProgress(ctx context.Context, ongoing *jobs, out progress.Output, start time.Time) error {
    for _, j := range ongoing.Jobs() {
        key := remotes.MakeRefKey(ctx, j)
        id := stringid.TruncateID(j.Digest.Encoded())
Severity: Minor
Found in daemon/containerd/progress.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pullProgress.UpdateProgress has 54 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (p pullProgress) UpdateProgress(ctx context.Context, ongoing *jobs, out progress.Output, start time.Time) error {
    actives, err := p.store.ListStatuses(ctx, "")
    if err != nil {
        if errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) {
            return err
Severity: Minor
Found in daemon/containerd/progress.go - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status