Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/daemon_windows.go

Summary

Maintainability
D
2 days
Test Coverage

Method Daemon.initNetworkController has a Cognitive Complexity of 75 (exceeds 20 allowed). Consider refactoring.
Open

func (daemon *Daemon) initNetworkController(daemonCfg *config.Config, activeSandboxes map[string]interface{}) error {
    netOptions, err := daemon.networkOptions(daemonCfg, nil, daemon.id, nil)
    if err != nil {
        return err
    }
Severity: Minor
Found in daemon/daemon_windows.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Daemon.initNetworkController has 134 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (daemon *Daemon) initNetworkController(daemonCfg *config.Config, activeSandboxes map[string]interface{}) error {
    netOptions, err := daemon.networkOptions(daemonCfg, nil, daemon.id, nil)
    if err != nil {
        return err
    }
Severity: Major
Found in daemon/daemon_windows.go - About 4 hrs to fix

    Function verifyPlatformContainerResources has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
    Open

    func verifyPlatformContainerResources(resources *containertypes.Resources, isHyperv bool) (warnings []string, err error) {
    fixMemorySwappiness(resources)
    if !isHyperv {
        // The processor resource controls are mutually exclusive on
        // Windows Server Containers, the order of precedence is
    Severity: Minor
    Found in daemon/daemon_windows.go - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function verifyPlatformContainerResources has 88 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func verifyPlatformContainerResources(resources *containertypes.Resources, isHyperv bool) (warnings []string, err error) {
    fixMemorySwappiness(resources)
    if !isHyperv {
        // The processor resource controls are mutually exclusive on
        // Windows Server Containers, the order of precedence is
    Severity: Major
    Found in daemon/daemon_windows.go - About 2 hrs to fix

      Function verifyPlatformContainerResources has 24 return statements (exceeds 4 allowed).
      Open

      func verifyPlatformContainerResources(resources *containertypes.Resources, isHyperv bool) (warnings []string, err error) {
    fixMemorySwappiness(resources)
    if !isHyperv {
        // The processor resource controls are mutually exclusive on
        // Windows Server Containers, the order of precedence is
      Severity: Major
      Found in daemon/daemon_windows.go - About 2 hrs to fix

        Method Daemon.initNetworkController has 8 return statements (exceeds 4 allowed).
        Open

        func (daemon *Daemon) initNetworkController(daemonCfg *config.Config, activeSandboxes map[string]interface{}) error {
    netOptions, err := daemon.networkOptions(daemonCfg, nil, daemon.id, nil)
    if err != nil {
        return err
    }
        Severity: Major
        Found in daemon/daemon_windows.go - About 50 mins to fix

          There are no issues that match your filters.

          Category
          Status