Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/exec.go

Summary

Maintainability
C
1 day
Test Coverage

Method Daemon.ContainerExecStart has 148 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (daemon *Daemon) ContainerExecStart(ctx context.Context, name string, options backend.ExecStartConfig) (err error) {
    var (
        cStdin           io.ReadCloser
        cStdout, cStderr io.Writer
    )
Severity: Major
Found in daemon/exec.go - About 4 hrs to fix

    Method Daemon.ContainerExecStart has a Cognitive Complexity of 39 (exceeds 20 allowed). Consider refactoring.
    Open

    func (daemon *Daemon) ContainerExecStart(ctx context.Context, name string, options backend.ExecStartConfig) (err error) {
    var (
        cStdin           io.ReadCloser
        cStdout, cStderr io.Writer
    )
    Severity: Minor
    Found in daemon/exec.go - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Daemon.ContainerExecStart has 12 return statements (exceeds 4 allowed).
    Open

    func (daemon *Daemon) ContainerExecStart(ctx context.Context, name string, options backend.ExecStartConfig) (err error) {
    var (
        cStdin           io.ReadCloser
        cStdout, cStderr io.Writer
    )
    Severity: Major
    Found in daemon/exec.go - About 1 hr to fix

      Method Daemon.getExecConfig has 6 return statements (exceeds 4 allowed).
      Open

      func (daemon *Daemon) getExecConfig(name string) (*container.ExecConfig, error) {
    ec := daemon.execCommands.Get(name)
    if ec == nil {
        return nil, errExecNotFound(name)
    }
      Severity: Major
      Found in daemon/exec.go - About 40 mins to fix

        Method Daemon.getActiveContainer has 5 return statements (exceeds 4 allowed).
        Open

        func (daemon *Daemon) getActiveContainer(name string) (*container.Container, error) {
    ctr, err := daemon.GetContainer(name)
    if err != nil {
        return nil, err
    }
        Severity: Major
        Found in daemon/exec.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status