Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/images/image_commit.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method ImageService.CommitImage has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) CommitImage(ctx context.Context, c backend.CommitConfig) (image.ID, error) {
    if err := ctx.Err(); err != nil {
        return "", err
    }
Severity: Minor
Found in daemon/images/image_commit.go - About 1 hr to fix

    Method ImageService.CommitImage has 9 return statements (exceeds 4 allowed).
    Open

    func (i *ImageService) CommitImage(ctx context.Context, c backend.CommitConfig) (image.ID, error) {
    if err := ctx.Err(); err != nil {
        return "", err
    }
    Severity: Major
    Found in daemon/images/image_commit.go - About 55 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (i *ImageService) CommitBuildStep(ctx context.Context, c backend.CommitConfig) (image.ID, error) {
    ctr := i.containers.Get(c.ContainerID)
    if ctr == nil {
        // TODO: use typed error
        return "", errors.Errorf("container not found: %s", c.ContainerID)
      Severity: Major
      Found in daemon/images/image_commit.go and 1 other location - About 1 hr to fix
      daemon/containerd/image_commit.go on lines 321..331

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 167.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status