Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/images/image_delete.go

Summary

Maintainability
C
1 day
Test Coverage

Method ImageService.ImageDelete has a Cognitive Complexity of 61 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) ImageDelete(ctx context.Context, imageRef string, force, prune bool) ([]imagetypes.DeleteResponse, error) {
    start := time.Now()
    records := []imagetypes.DeleteResponse{}

    img, err := i.GetImage(ctx, imageRef, backend.GetImageOpts{})
Severity: Minor
Found in daemon/images/image_delete.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.ImageDelete has 82 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) ImageDelete(ctx context.Context, imageRef string, force, prune bool) ([]imagetypes.DeleteResponse, error) {
    start := time.Now()
    records := []imagetypes.DeleteResponse{}

    img, err := i.GetImage(ctx, imageRef, backend.GetImageOpts{})
Severity: Major
Found in daemon/images/image_delete.go - About 2 hrs to fix

    Method ImageService.ImageDelete has 11 return statements (exceeds 4 allowed).
    Open

    func (i *ImageService) ImageDelete(ctx context.Context, imageRef string, force, prune bool) ([]imagetypes.DeleteResponse, error) {
    start := time.Now()
    records := []imagetypes.DeleteResponse{}

    img, err := i.GetImage(ctx, imageRef, backend.GetImageOpts{})
    Severity: Major
    Found in daemon/images/image_delete.go - About 1 hr to fix

      Method ImageService.checkImageDeleteConflict has 7 return statements (exceeds 4 allowed).
      Open

      func (i *ImageService) checkImageDeleteConflict(imgID image.ID, mask conflictType) *imageDeleteConflict {
    // Check if the image has any descendant images.
    if mask&conflictDependentChild != 0 && len(i.imageStore.Children(imgID)) > 0 {
        return &imageDeleteConflict{
            hard:    true,
      Severity: Major
      Found in daemon/images/image_delete.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if _, err := i.removeImageRef(repoRef); err != nil {
                            return records, err
                        }
        Severity: Major
        Found in daemon/images/image_delete.go - About 45 mins to fix

          Method ImageService.imageDeleteHelper has 6 return statements (exceeds 4 allowed).
          Open

          func (i *ImageService) imageDeleteHelper(imgID image.ID, records *[]imagetypes.DeleteResponse, force, prune, quiet bool) error {
    // First, determine if this image has any conflicts. Ignore soft conflicts
    // if force is true.
    c := conflictHard
    if !force {
          Severity: Major
          Found in daemon/images/image_delete.go - About 40 mins to fix

            There are no issues that match your filters.

            Category
            Status