Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/images/image_prune.go

Summary

Maintainability
C
1 day
Test Coverage

Method ImageService.ImagesPrune has a Cognitive Complexity of 63 (exceeds 20 allowed). Consider refactoring.
Open

func (i *ImageService) ImagesPrune(ctx context.Context, pruneFilters filters.Args) (*imagetypes.PruneReport, error) {
    if !i.pruneRunning.CompareAndSwap(false, true) {
        return nil, errPruneRunning
    }
    defer i.pruneRunning.Store(false)
Severity: Minor
Found in daemon/images/image_prune.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ImageService.ImagesPrune has 102 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (i *ImageService) ImagesPrune(ctx context.Context, pruneFilters filters.Args) (*imagetypes.PruneReport, error) {
    if !i.pruneRunning.CompareAndSwap(false, true) {
        return nil, errPruneRunning
    }
    defer i.pruneRunning.Store(false)
Severity: Major
Found in daemon/images/image_prune.go - About 3 hrs to fix

    Method ImageService.ImagesPrune has 6 return statements (exceeds 4 allowed).
    Open

    func (i *ImageService) ImagesPrune(ctx context.Context, pruneFilters filters.Args) (*imagetypes.PruneReport, error) {
    if !i.pruneRunning.CompareAndSwap(false, true) {
        return nil, errPruneRunning
    }
    defer i.pruneRunning.Store(false)
    Severity: Major
    Found in daemon/images/image_prune.go - About 40 mins to fix

      Function getUntilFromPruneFilters has 5 return statements (exceeds 4 allowed).
      Open

      func getUntilFromPruneFilters(pruneFilters filters.Args) (time.Time, error) {
    until := time.Time{}
    if !pruneFilters.Contains("until") {
        return until, nil
    }
      Severity: Major
      Found in daemon/images/image_prune.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status