Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/inspect.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Daemon.getInspectData has 73 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (daemon *Daemon) getInspectData(daemonCfg *config.Config, container *container.Container) (*containertypes.ContainerJSONBase, error) {
    // make a copy to play with
    hostConfig := *container.HostConfig

    children := daemon.children(container)
Severity: Minor
Found in daemon/inspect.go - About 1 hr to fix

    Method Daemon.ContainerInspect has 51 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (daemon *Daemon) ContainerInspect(ctx context.Context, name string, options backend.ContainerInspectOptions) (*containertypes.InspectResponse, error) {
    ctr, err := daemon.GetContainer(name)
    if err != nil {
        return nil, err
    }
    Severity: Minor
    Found in daemon/inspect.go - About 1 hr to fix

      Method Daemon.getInspectData has 6 return statements (exceeds 4 allowed).
      Open

      func (daemon *Daemon) getInspectData(daemonCfg *config.Config, container *container.Container) (*containertypes.ContainerJSONBase, error) {
    // make a copy to play with
    hostConfig := *container.HostConfig

    children := daemon.children(container)
      Severity: Major
      Found in daemon/inspect.go - About 40 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            return containertypes.DefaultNetworkSettings{
        EndpointID:          nw.EndpointSettings.EndpointID,
        Gateway:             nw.EndpointSettings.Gateway,
        GlobalIPv6Address:   nw.EndpointSettings.GlobalIPv6Address,
        GlobalIPv6PrefixLen: nw.EndpointSettings.GlobalIPv6PrefixLen,
        Severity: Minor
        Found in daemon/inspect.go and 1 other location - About 40 mins to fix
        daemon/inspect.go on lines 49..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                NetworkSettingsBase: containertypes.NetworkSettingsBase{
            Bridge:                 ctr.NetworkSettings.Bridge,
            SandboxID:              ctr.NetworkSettings.SandboxID,
            SandboxKey:             ctr.NetworkSettings.SandboxKey,
            HairpinMode:            ctr.NetworkSettings.HairpinMode,
        Severity: Minor
        Found in daemon/inspect.go and 1 other location - About 40 mins to fix
        daemon/inspect.go on lines 229..238

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status