Sign upLogin

dotcloud/docker

View on GitHub
Star
daemon/logger/gelf/gelf.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function New has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func New(info logger.Info) (logger.Logger, error) {
    // parse gelf address
    address, err := parseAddress(info.Config["gelf-address"])
    if err != nil {
        return nil, err
Severity: Minor
Found in daemon/logger/gelf/gelf.go - About 1 hr to fix

    Function New has 10 return statements (exceeds 4 allowed).
    Open

    func New(info logger.Info) (logger.Logger, error) {
    // parse gelf address
    address, err := parseAddress(info.Config["gelf-address"])
    if err != nil {
        return nil, err
    Severity: Major
    Found in daemon/logger/gelf/gelf.go - About 1 hr to fix

      Function ValidateLogOpt has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func ValidateLogOpt(cfg map[string]string) error {
    address, err := parseAddress(cfg["gelf-address"])
    if err != nil {
        return err
    }
      Severity: Minor
      Found in daemon/logger/gelf/gelf.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ValidateLogOpt has 7 return statements (exceeds 4 allowed).
      Open

      func ValidateLogOpt(cfg map[string]string) error {
    address, err := parseAddress(cfg["gelf-address"])
    if err != nil {
        return err
    }
      Severity: Major
      Found in daemon/logger/gelf/gelf.go - About 45 mins to fix

        Function parseAddress has 5 return statements (exceeds 4 allowed).
        Open

        func parseAddress(address string) (*url.URL, error) {
    if address == "" {
        return nil, fmt.Errorf("gelf-address is a required parameter")
    }
    addr, err := url.Parse(address)
        Severity: Major
        Found in daemon/logger/gelf/gelf.go - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status